Repository navigation
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
complex/float32/parse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves None.
Description
This pull request:
README.mdofcomplex/float32/parseto use complex number instance notation (<Complex64>[ 5.0, 3.0 ]) instead of decomposing the parsed value withrealandimag.realandimagrequires from that example, as they are no longer used there.The
Examplessection is unchanged, since it usesrealandimagfor value checks rather than for showing expected output.Related Issues
This pull request has the following related issues:
Questions
No.
Other
I followed the changes in commit e8c8651 as a model. I'm on Windows and was not able to run the project's lint checks locally, so I'm relying on CI for those.
Checklist
@stdlib-js/reviewers