Skip to content

chore: fix C lint errors (issue #16454) - #16505

Open
BhavyaB19 wants to merge 2 commits into
stdlib-js:developfrom
BhavyaB19:fix/ndarray-unary-c-lint
Open

BhavyaB19 wants to merge 2 commits into
stdlib-js:developfrom
BhavyaB19:fix/ndarray-unary-c-lint

Conversation

@BhavyaB19

Copy link
Copy Markdown

Resolves #16454 .

Description

What is the purpose of this pull request?

This pull request:

  • fixes C lint errors in ndarray/base/unary by declaring the stride pointers s1 and s2 in stdlib_ndarray_unary_dispatch as pointers to const, as they are only read and are passed to stdlib_ndarray_iteration_order, which already accepts const int64_t *.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • ndarray/base/unary-accumulate

What carried over from the reference(s)?

  • The same constVariablePointer fix applied in d6065f1, including moving the declarations to preserve the longest-to-shortest ordering of variable declarations.

What differed, or what did you have to work out yourself?

  • Nothing significant, this package has two stride pointers (s1, s2) instead of one.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used Claude Code to understand the codebase, find the relevant files and identify the issue.


@stdlib-js/reviewers

@BhavyaB19
BhavyaB19 requested a review from a team November 5, 2026 05:06
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels Nov 5, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Nov 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

2 participants