Repository navigation
docs: remove non-applicable buffer parameters - #16489
Merged
Merged
Conversation
…ric` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD79iV3tw6GX5fE7nsXj
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD79iV3tw6GX5fE7nsXj
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
November 5, 2026 23:33
kgryte
approved these changes
Nov 5, 2026
Member
Author
|
The
Generated by Claude Code |
Member
|
As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge. |
kgryte
approved these changes
Nov 6, 2026
GenericVector declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
Follow-up fixes for commits merged to
developbetween 2026-11-03T22:34:19Z (b2c3ac9) and 2026-11-04T10:21:21Z (2693b6b).ndarray/vector/generic@paramentries from thectorJSDoc inndarray/vector/generic/docs/types/index.d.ts. They came in with d7bef11 fromndarray/vector/float64. Theargdescription no longer mentions "buffer", and thebyteOffsetandlengthparams are removed:GenericVectorthrows onArrayBufferinput and accepts neither.ndarray/vectorGenericVectorJSDoc inndarray/vector/docs/types/index.d.ts, which dc28a63 (the auto-generated namespace declaration update) copied from the outdated package docs. Drops "buffer" from theargdescription and removes thebyteOffsetandlengthparams, matchingndarray/vector/generic.GenericVectorthrows on anArrayBuffer.Related Issues
None.
Reference Packages
This pull request followed these packages:
ndarray/vector/generic(itslib/main.jsJSDoc andGenericVectorinterface overloads)@param argdescription fromndarray/vector/generic/lib/main.js.Questions
No.
Other
Validation
developin the window. Two independent passes checked compliance withdocs/style-guidesagainst reference packages. Two independent passes scanned the diff for bugs. Three of the four flagged this issue independently.ndarray/vector/generic/lib/main.js(it throws aTypeErroronArrayBuffer),test/test.js, and the interface overloads.repl.txt), and anything that needs interpretation or changes outside the diff window. For example,_tools/pkgs/entry-points/lib/sync.jsstill has the callback@throwstag that 7f74397 removed from its siblings, but that file is not in the window.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as part of an automated daily review of commits merged to
develop.@stdlib-js/reviewers
Generated by Claude Code