Skip to content

build: update kaciras/deasync - #16488

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
AryanSharma48:update-deasync-latest
Nov 4, 2026
Merged

kgryte merged 2 commits into
stdlib-js:developfrom
AryanSharma48:update-deasync-latest

Conversation

@AryanSharma48

Copy link
Copy Markdown
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • Bumps @kaciras/deasync to ^1.2.4 in package.json and etc/npm/deps.txt. Upstream releases 1.2.0 through 1.2.3 were published with missing native build configuration files and broken install scripts, causing make install-node-modules to fail globally across CI runs with binding.gyp not found. Version 1.2.4 resolves this upstream by removing the native install scripts and directly bundling pre-compiled binaries for supported platforms.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • None

What carried over from the reference(s)?

  • N/A

What differed, or what did you have to work out yourself?

  • N/A

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

N/A


@stdlib-js/reviewers

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
@AryanSharma48
AryanSharma48 requested a review from a team November 4, 2026 09:04
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 4, 2026
@socket-security

socket-security Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​kaciras/​deasync@​1.1.0 ⏵ 1.2.491 +810010092 +12100

View full report

@AryanSharma48

Copy link
Copy Markdown
Contributor Author

cc: @Planeshifter

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 4, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for following up on this, @AryanSharma48, and for tracking the progress in the upstream resolution.

@kgryte kgryte changed the title build: update kaciras/deasync to ^1.2.4 build: update kaciras/deasync Nov 4, 2026
@kgryte
kgryte merged commit a375a9a into stdlib-js:develop Nov 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants