Repository navigation
feat: add C implementation for blas/ext/base/ndarray/dvander - #16486
Open
utkarshpatwa393-sys wants to merge 1 commit into
Open
utkarshpatwa393-sys wants to merge 1 commit into
utkarshpatwa393-sys wants to merge 1 commit into
Conversation
Signed-off-by: Utkarsh patwa <utkarshpatwa393@gmail.com>
stdlib-bot
added
BLAS
ujjwalv01
reviewed
Nov 4, 2026
|
|
||
| <!-- /.examples --> | ||
|
|
||
| <!-- C part. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> |
Member
There was a problem hiding this comment.
Suggested change
| <!-- C part. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | |
| <!-- C interface documentation. --> | |
| * * * |
ujjwalv01
reviewed
Nov 4, 2026
|
|
||
| <!-- /.notes --> | ||
|
|
||
| <!-- C device examples. --> |
Member
There was a problem hiding this comment.
Suggested change
| <!-- C device examples. --> | |
| <!-- C API usage examples. --> |
ujjwalv01
reviewed
Nov 4, 2026
| #include <stdlib.h> | ||
| #include <stdio.h> | ||
|
|
||
| int main( void ) { |
Member
There was a problem hiding this comment.
The README C example should match examples/c/example.c exactly (minus the cppcheck-suppress lines); several comments and declarations are missing here.
ujjwalv01
reviewed
Nov 4, 2026
| int i; | ||
| int j; | ||
|
|
||
| print_version(); |
Member
There was a problem hiding this comment.
Suggested change
| print_version(); | |
| // Use the current time to seed the random number generator: | |
| srand( time( NULL ) ); | |
| print_version(); |
ujjwalv01
reviewed
Nov 4, 2026
| printf( "# c::%s:len=%d\n", NAME, len ); | ||
| elapsed = benchmark( iter, len ); | ||
| print_results( iter, elapsed ); | ||
| printf( "ok %d - benchmark finished\n", count ); |
Member
There was a problem hiding this comment.
Suggested change
| printf( "ok %d - benchmark finished\n", count ); | |
| printf( "ok %d benchmark finished\n", count ); |
Member
|
Left few suggestions; |
ujjwalv01
added
Needs Changes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #14819
Description
This pull request:
blas/ext/base/ndarray/dvanderRelated Issues
This pull request has the following related issues:
blas/ext/base/ndarraypackages #14819Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
AI assistance was used for reviewing changes and research. All files, C compilation with -Wall -Wextra -pedantic, JS/native test suites, benchmarks, and linting have been verified.
@stdlib-js/reviewers