Repository navigation
style: fix lint errors in wasm/module-wrapper and stats/kde2d - #16475
Draft
Planeshifter wants to merge 1 commit into
Draft
Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
The `lint_random_files` workflow failed on develop with `n/no-unsupported-features/node-builtins` errors for `WebAssembly` in `wasm/module-wrapper/lib/main.js` and a `stdlib/line-closing-bracket-spacing` error in `stats/kde2d/lib/main.js`. The `WebAssembly` uses are intentional and guarded by a feature check, so this commit adds the rule to the file-level `eslint-disable` directive. It also removes the space between `}` and `)` in the `ndarray` call in `kde2d`. Ref: https://github.com/stdlib-js/stdlib/actions/runs/41549745345 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD77pJkCuf6ZMu1MPXBK
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
lint_random_filesworkflow to fail ondevelop(run).n/no-unsupported-features/node-builtinsto the file-leveleslint-disableinwasm/module-wrapper/lib/main.js. TheWebAssemblyuses are intentional and guarded byhasWebAssemblySupport().}and)in thendarraycall instats/kde2d/lib/main.js(stdlib/line-closing-bracket-spacing).Questions
No.
Other
Symptom: 4
n/no-unsupported-features/node-builtinserrors (lines 199, 251, 297, 298) and 1stdlib/line-closing-bracket-spacingerror. ESLint is not installed in the authoring environment, so the fix was not linted locally; it was reviewed against the rule sources by three independent reviewers (all approve).Non-blocking note: most of the repository uses per-line
eslint-disable-linefor this rule. The flagged lines already carry trailing// TODOcomments, so a file-level disable was used.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as part of an automated CI-failure triage routine.
@stdlib-js/reviewers
Generated by Claude Code