Skip to content

style: fix lint errors in wasm/module-wrapper and stats/kde2d - #16475

Draft
Planeshifter wants to merge 1 commit into
developfrom
claude/elegant-feynman-r7m6t1
Draft

Planeshifter wants to merge 1 commit into
developfrom
claude/elegant-feynman-r7m6t1

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • fixes lint errors that caused the lint_random_files workflow to fail on develop (run).
  • adds n/no-unsupported-features/node-builtins to the file-level eslint-disable in wasm/module-wrapper/lib/main.js. The WebAssembly uses are intentional and guarded by hasWebAssemblySupport().
  • removes the space between } and ) in the ndarray call in stats/kde2d/lib/main.js (stdlib/line-closing-bracket-spacing).

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Symptom: 4 n/no-unsupported-features/node-builtins errors (lines 199, 251, 297, 298) and 1 stdlib/line-closing-bracket-spacing error. ESLint is not installed in the authoring environment, so the fix was not linted locally; it was reviewed against the rule sources by three independent reviewers (all approve).

Non-blocking note: most of the repository uses per-line eslint-disable-line for this rule. The flagged lines already carry trailing // TODO comments, so a file-level disable was used.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code as part of an automated CI-failure triage routine.


@stdlib-js/reviewers


Generated by Claude Code

The `lint_random_files` workflow failed on develop with
`n/no-unsupported-features/node-builtins` errors for `WebAssembly` in
`wasm/module-wrapper/lib/main.js` and a
`stdlib/line-closing-bracket-spacing` error in `stats/kde2d/lib/main.js`.

The `WebAssembly` uses are intentional and guarded by a feature check,
so this commit adds the rule to the file-level `eslint-disable`
directive. It also removes the space between `}` and `)` in the
`ndarray` call in `kde2d`.

Ref: https://github.com/stdlib-js/stdlib/actions/runs/41549745345

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD77pJkCuf6ZMu1MPXBK
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/kde2d $\\color{red}1226/1312$
$\\color{green}+93.45\\%$
$\\color{red}96/103$
$\\color{green}+93.20\\%$
$\\color{red}13/20$
$\\color{green}+65.00\\%$
$\\color{red}1226/1312$
$\\color{green}+93.45\\%$
wasm/module-wrapper $\\color{red}409/514$
$\\color{green}+79.57\\%$
$\\color{red}11/18$
$\\color{green}+61.11\\%$
$\\color{red}7/20$
$\\color{green}+35.00\\%$
$\\color{red}409/514$
$\\color{green}+79.57\\%$

The above coverage report was generated for the changes in this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants