Skip to content

chore: clean-up - #16465

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-11-02
Nov 3, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-11-02

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-11-01T12:17Z and 2026-11-02T12:17Z (one commit: d6ddcf5).

This pull request:

_tools/semantic-document/to-ipynb

  • Fix EXAMPLE in test/test.js to point to abs.md.txt (d6ddcf5). The previous path, examples/fixtures/example.md.txt, does not exist, so the package resolution, C section exclusion, and source-order recovery exclusion tests fail. abs.md.txt is the fixture used by the example and contains the content those tests assert on.
  • Fix target validation in lib/validate.js (d6ddcf5) by using @stdlib/assert/has-own-property. Inherited keys such as 'constructor' and 'toString' previously passed the targets lookup and crashed conversion on target.kernelspec instead of throwing the "Unsupported JupyterLite target" error.
  • Fix checkGlobals in lib/lower_jupyterlite_javascript.js (d6ddcf5) to use hasOwnProp when looking up FORBIDDEN_GLOBALS and WORKER_FORBIDDEN_GLOBALS. Valid code referencing inherited Object.prototype names (e.g., toString.call( [] ), hasOwnProperty) was previously rejected, with the inherited function used as the failure code.
  • Remove "doc": "./docs" from directories in package.json (d6ddcf5). The package has no docs directory, and lint_package_json_files fails on it in "Lint Changed Files".

Related Issues

Does this pull request have any related issues?

None.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • None. These are fixes to an existing package.

What carried over from the reference(s)?

  • Not applicable.

What differed, or what did you have to work out yourself?

  • Not applicable.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

  • Checked: stdlib style-guide compliance against docs/style-guides and sibling _tools/semantic-document/* packages (two independent passes), plus two independent bug and logic scans of the diff. Each fix was re-verified against the source. validate( { 'target': 'constructor' } ) now throws, and the jupyterlite-iframe and default targets still validate. The package.json change is exactly the diff that lint_package_json_files requests.
  • Excluded (judgment calls or outside the diff window):
    • + operator spacing. Lint passed, and the spacing is consistent throughout the package.
    • README API heading levels. No style guide rule covers them.
    • Stricter moduleMap URL validation. The fix changes behavior and would also reject uppercase hosts and bare origins.
    • eslint-scope missing from the root package.json. The root package.json is outside the diff.
    • The same inherited-key pattern in the OPTION_KEYS, allowed and checkDirectives tables. The impact is low: unknown keys such as constructor are silently accepted.
  • Not run: the test suite, because dependencies are not installed in this environment.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated daily review of commits merged to develop.


🤖 Generated with Claude Code

https://claude.ai/code/session_017wWD78vQdpXmymVqF9SDgE

…ntic-document/to-ipynb`

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD78vQdpXmymVqF9SDgE
@stdlib-bot stdlib-bot added the Tools Issue or pull request related to project tooling. label Nov 2, 2026
…ment/to-ipynb` package.json

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD78vQdpXmymVqF9SDgE
@kgryte
kgryte marked this pull request as ready for review November 3, 2026 23:11
@kgryte
kgryte requested a review from a team November 3, 2026 23:11
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 3, 2026
@kgryte kgryte changed the title fix: use own-property checks and correct test fixture in _tools/semantic-document/to-ipynb chore: clean-up Nov 3, 2026
@kgryte
kgryte merged commit 052af17 into develop Nov 3, 2026
31 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-11-02 branch November 3, 2026 23:12
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants