Repository navigation
chore: clean-up - #16465
Merged
Merged
chore: clean-up#16465
Conversation
…ntic-document/to-ipynb` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD78vQdpXmymVqF9SDgE
…ment/to-ipynb` package.json Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD78vQdpXmymVqF9SDgE
kgryte
approved these changes
Nov 3, 2026
_tools/semantic-document/to-ipynb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-11-01T12:17Z and 2026-11-02T12:17Z (one commit: d6ddcf5).This pull request:
_tools/semantic-document/to-ipynbEXAMPLEintest/test.jsto point toabs.md.txt(d6ddcf5). The previous path,examples/fixtures/example.md.txt, does not exist, so the package resolution, C section exclusion, and source-order recovery exclusion tests fail.abs.md.txtis the fixture used by the example and contains the content those tests assert on.targetvalidation inlib/validate.js(d6ddcf5) by using@stdlib/assert/has-own-property. Inherited keys such as'constructor'and'toString'previously passed thetargetslookup and crashed conversion ontarget.kernelspecinstead of throwing the "Unsupported JupyterLitetarget" error.checkGlobalsinlib/lower_jupyterlite_javascript.js(d6ddcf5) to usehasOwnPropwhen looking upFORBIDDEN_GLOBALSandWORKER_FORBIDDEN_GLOBALS. Valid code referencing inheritedObject.prototypenames (e.g.,toString.call( [] ),hasOwnProperty) was previously rejected, with the inherited function used as the failure code."doc": "./docs"fromdirectoriesinpackage.json(d6ddcf5). The package has nodocsdirectory, andlint_package_json_filesfails on it in "Lint Changed Files".Related Issues
None.
Reference Packages
This pull request followed these packages:
Questions
No.
Other
Validation
docs/style-guidesand sibling_tools/semantic-document/*packages (two independent passes), plus two independent bug and logic scans of the diff. Each fix was re-verified against the source.validate( { 'target': 'constructor' } )now throws, and thejupyterlite-iframeand default targets still validate. Thepackage.jsonchange is exactly the diff thatlint_package_json_filesrequests.+operator spacing. Lint passed, and the spacing is consistent throughout the package.moduleMapURL validation. The fix changes behavior and would also reject uppercase hosts and bare origins.eslint-scopemissing from the rootpackage.json. The rootpackage.jsonis outside the diff.OPTION_KEYS,allowedandcheckDirectivestables. The impact is low: unknown keys such asconstructorare silently accepted.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as part of an automated daily review of commits merged to
develop.🤖 Generated with Claude Code
https://claude.ai/code/session_017wWD78vQdpXmymVqF9SDgE