Skip to content

chore: fix C lint errors (issue #16454) - #16464

Open
raus7n wants to merge 1 commit into
stdlib-js:developfrom
raus7n:fix/c-lint-16454
Open

raus7n wants to merge 1 commit into
stdlib-js:developfrom
raus7n:fix/c-lint-16454

Conversation

@raus7n

@raus7n raus7n commented Nov 2, 2026

Copy link
Copy Markdown

Description

This pull request fixes the C lint errors in ndarray/base/unary/src/dispatch.c by declaring s1 and s2 as pointers to const.

Both pointers are only used to read stride values, so there is no change in behavior.

Related Issues

Questions

No.

Other

No.

Checklist

AI Assistance

  • Yes

  • No

  • Code generation

  • Test/benchmark generation

  • Documentation (including examples)

  • Research and understanding

@raus7n
raus7n requested a review from a team November 2, 2026 07:26
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 2, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels Nov 2, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

2 participants