Repository navigation
chore: clean-up - #16437
Merged
Merged
chore: clean-up#16437
Conversation
Propagates fix from d213b8d ("docs: add missing blank line") to a sibling C doc comment in which the description runs directly into the first `@param` tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW
Propagates fix from d918587 ("docs: remove obsolete annotation") to `ndarray/fancy`, which delegates to `ndarray/ctor` and likewise never throws when `shape` length mismatches the number of dimensions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW
Propagates fix from 2d7198f ("style: add missing space") to sibling `lib/` sources containing call expressions or parameter lists lacking a space before the closing parenthesis. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Fixes `stdlib/tsdoc-declarations-doctest` failures ("FancyArray is not defined"), as the declaration examples reference `FancyArray` while the export is declared as `ctor`. Mirrors the alias used in `ndarray/ctor`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW
kgryte
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-10-31T13:08Z and 2026-11-01T13:08Z to sibling packages.docs: add missing blank line): inserts the missing blank comment line between a C doc comment's description and its first@paramtag.math/base/special/kernel-betaincdocs: remove obsolete annotation): removes the@throwsannotation for ashapelength/dimension mismatch.ndarray/fancydelegates tondarray/ctor, which derives the number of dimensions fromshape, so the error cannot occur.ndarray/fancy(lib/main.js,docs/types/index.d.ts)style: add missing space): adds the missing space before a closing parenthesis inlib/sources._tools/github/starred_tools/github/user-reposblas/ext/base/dsnansumblas/ext/base/gcusumpwndarray/base/nullary-strided1dstats/base/dists/binomial/quantilestats/base/dists/levy/quantilestats/kde2dstats/pcorrteststats/strided/nanmskrangestats/strided/range-by// eslint-doctest-alias: FancyArraytondarray/fancy/docs/types/index.d.ts, mirroringndarray/ctor. Touching the file surfaced a pre-existingstdlib/tsdoc-declarations-doctestfailure ("FancyArray is not defined"): the examples referenceFancyArray, but the export is declared asctor.Related Issues
No.
Reference Packages
This pull request followed these packages:
stats/base/dists/exponential/quantile,ndarray/ctor(source commits listed above)kernel-betainc, the description that runs into the first@paramends in a closing code fence rather than prose.Questions
No.
Other
Validation. Candidate sites were found by pattern search over the relevant namespaces (
lib/**/*.jsfor the paren spacing, all*.c/*.hfor the doc-comment gap, the full tree for the@throwstext). Every site was confirmed by two independent validation passes, an adaptation pass, and a style-consistency pass. All 17 sites passed all four.Excluded:
ndarray/docs/types/index.d.ts: regenerated by the bot. It will pick up thendarray/fancychange on the next regeneration.repl,ndarray/base/dtypes2signatures,number/uint64/base/string2words).lib/scope.dcopy/scopyunrolled-loop index advance). For d17633f (napi header clean-up), the only candidate wasargv-dataview; it is ambiguous whether a DataView counts as "the array", so it was dropped.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as part of an automated fix-propagation routine.
🤖 Generated with Claude Code
https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW