Skip to content

chore: clean-up - #16437

Merged
kgryte merged 4 commits into
developfrom
claude/trusting-cannon-17bpv8
Nov 3, 2026
Merged

kgryte merged 4 commits into
developfrom
claude/trusting-cannon-17bpv8

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-10-31T13:08Z and 2026-11-01T13:08Z to sibling packages.
  • d213b8d (docs: add missing blank line): inserts the missing blank comment line between a C doc comment's description and its first @param tag.
    • math/base/special/kernel-betainc
  • d918587 (docs: remove obsolete annotation): removes the @throws annotation for a shape length/dimension mismatch. ndarray/fancy delegates to ndarray/ctor, which derives the number of dimensions from shape, so the error cannot occur.
    • ndarray/fancy (lib/main.js, docs/types/index.d.ts)
  • 2d7198f (style: add missing space): adds the missing space before a closing parenthesis in lib/ sources.
    • _tools/github/starred
    • _tools/github/user-repos
    • blas/ext/base/dsnansum
    • blas/ext/base/gcusumpw
    • ndarray/base/nullary-strided1d
    • stats/base/dists/binomial/quantile
    • stats/base/dists/levy/quantile
    • stats/kde2d
    • stats/pcorrtest
    • stats/strided/nanmskrange
    • stats/strided/range-by
  • adds // eslint-doctest-alias: FancyArray to ndarray/fancy/docs/types/index.d.ts, mirroring ndarray/ctor. Touching the file surfaced a pre-existing stdlib/tsdoc-declarations-doctest failure ("FancyArray is not defined"): the examples reference FancyArray, but the export is declared as ctor.

Related Issues

Does this pull request have any related issues?

No.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • stats/base/dists/exponential/quantile, ndarray/ctor (source commits listed above)

What carried over from the reference(s)?

  • Each change mirrors its source commit's change.

What differed, or what did you have to work out yourself?

  • In kernel-betainc, the description that runs into the first @param ends in a closing code fence rather than prose.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. Candidate sites were found by pattern search over the relevant namespaces (lib/**/*.js for the paren spacing, all *.c/*.h for the doc-comment gap, the full tree for the @throws text). Every site was confirmed by two independent validation passes, an adaptation pass, and a style-consistency pass. All 17 sites passed all four.

Excluded:

  • ndarray/docs/types/index.d.ts: regenerated by the bot. It will pick up the ndarray/fancy change on the next regeneration.
  • Paren-spacing matches inside string literals (repl, ndarray/base/dtypes2signatures, number/uint64/base/string2words).
  • Paren-spacing matches in tests, benchmarks, examples, and scripts. Left out to keep the change within the source commit's lib/ scope.
  • No sibling sites were found for c73cd1e (dcopy/scopy unrolled-loop index advance). For d17633f (napi header clean-up), the only candidate was argv-dataview; it is ambiguous whether a DataView counts as "the array", so it was dropped.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated fix-propagation routine.


🤖 Generated with Claude Code

https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW

Propagates fix from d213b8d ("docs: add missing blank line") to a sibling C doc comment in which the description runs directly into the first `@param` tag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW
Propagates fix from d918587 ("docs: remove obsolete annotation") to `ndarray/fancy`, which delegates to `ndarray/ctor` and likewise never throws when `shape` length mismatches the number of dimensions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW
Propagates fix from 2d7198f ("style: add missing space") to sibling `lib/` sources containing call expressions or parameter lists lacking a space before the closing parenthesis.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW
@stdlib-bot

stdlib-bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsnansum $\\color{green}345/345$
$\\color{green}+0.00\\%$
$\\color{green}13/13$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}345/345$
$\\color{green}+0.00\\%$
blas/ext/base/gcusumpw $\\color{green}346/346$
$\\color{green}+0.00\\%$
$\\color{green}18/18$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}346/346$
$\\color{green}+0.00\\%$
math/base/special/kernel-betainc $\\color{red}1699/1788$
$\\color{green}+0.00\\%$
$\\color{red}239/256$
$\\color{green}+0.00\\%$
$\\color{green}16/16$
$\\color{green}+0.00\\%$
$\\color{red}1699/1788$
$\\color{green}+0.00\\%$
ndarray/base/nullary-strided1d $\\color{red}4059/7371$
$\\color{green}+0.00\\%$
$\\color{red}34/35$
$\\color{green}+0.00\\%$
$\\color{red}2/37$
$\\color{green}+0.00\\%$
$\\color{red}4059/7371$
$\\color{green}+0.00\\%$
ndarray/fancy $\\color{green}151/151$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}151/151$
$\\color{green}+0.00\\%$
stats/base/dists/binomial/quantile $\\color{red}522/524$
$\\color{green}+0.00\\%$
$\\color{red}61/62$
$\\color{green}+0.00\\%$
$\\color{green}6/6$
$\\color{green}+0.00\\%$
$\\color{red}522/524$
$\\color{green}+0.00\\%$
stats/base/dists/levy/quantile $\\color{green}295/295$
$\\color{green}+0.00\\%$
$\\color{green}23/23$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}295/295$
$\\color{green}+0.00\\%$
stats/kde2d $\\color{red}1226/1312$
$\\color{green}+0.00\\%$
$\\color{red}96/103$
$\\color{green}+0.00\\%$
$\\color{red}13/20$
$\\color{green}+0.00\\%$
$\\color{red}1226/1312$
$\\color{green}+0.00\\%$
stats/pcorrtest $\\color{green}519/519$
$\\color{green}+0.00\\%$
$\\color{green}83/83$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}519/519$
$\\color{green}+0.00\\%$
stats/strided/nanmskrange $\\color{green}331/331$
$\\color{green}+0.00\\%$
$\\color{green}42/42$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}331/331$
$\\color{green}+0.00\\%$
stats/strided/range-by $\\color{green}340/340$
$\\color{green}+0.00\\%$
$\\color{green}52/52$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}340/340$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

Fixes `stdlib/tsdoc-declarations-doctest` failures ("FancyArray is not defined"), as the declaration examples reference `FancyArray` while the export is declared as `ctor`. Mirrors the alias used in `ndarray/ctor`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7BKpboBu8CFoDkNRsW
@kgryte
kgryte marked this pull request as ready for review November 3, 2026 23:13
@kgryte
kgryte requested a review from a team November 3, 2026 23:13
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 3, 2026
@kgryte kgryte changed the title style: propagate recent doc and style fixes to sibling packages chore: clean-up Nov 3, 2026
@kgryte
kgryte merged commit b7ad899 into develop Nov 3, 2026
34 checks passed
@kgryte
kgryte deleted the claude/trusting-cannon-17bpv8 branch November 3, 2026 23:15
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants