Repository navigation
chore: clean-up - #16436
Merged
Merged
chore: clean-up#16436
Conversation
…rraybuffer` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD79mcKgFp6uqWTuGTWj
…/special/cinv` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD79mcKgFp6uqWTuGTWj
…ial/cinvf` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wWD79mcKgFp6uqWTuGTWj
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Nov 3, 2026
develop on 2026-10-31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-10-31T19:46:31Z (2f24c6d5d) and 2026-11-01T04:57:50Z (7be647734).This pull request:
ndarray/from-arraybufferRangeError: Invalid typed array length: 1for empty shapes inlib/node_modules/@stdlib/ndarray/from-arraybuffer/lib/main.js(added in 2f24c6d). Whennumel( shape ) === 0,minmaxViewBufferIndexreturns[0,0], yieldingN = 1and an invalid view fornew ArrayBuffer( 0 )orbyteOffset === byteLength;Nis now( numel( shape ) === 0 ) ? 0 : idx[ 1 ] - idx[ 0 ] + 1. This restoresvector( new ArrayBuffer( 0 ), 'float64' ), which regressed in af38320 whenndarray/vector/ctorswitched to this package.[@stdlib/array/buffer]link definition inlib/node_modules/@stdlib/ndarray/from-arraybuffer/README.md. The reference is used on lines 25 and 47 but was never defined (2f24c6d). Also remove the unused[@stdlib/ndarray/orders]and[@stdlib/ndarray/index-modes]definitions.math/base/special/cinvmath/base/special/cinv/README.mdwithexamples/c/example.cby changingint main() {toint main( void ) {, following the signature change in 2a22c73.math/base/special/cinvfuniformcall inmath/base/special/cinvf/README.mdwithexamples/index.js, which 8729960 updated touniform( 200, -100.0, 100.0, { 'dtype': 'float32' } ). Matchescsignumf.Related Issues
None.
Reference Packages
This pull request followed these packages:
Questions
No.
Other
Validation
blas/ext/base/daxpby,stats/base/dists/beta/pdf,math/base/special/cexp), and two agents scanned for bugs. The two bug scanners found thefrom-arraybufferempty-shape bug independently.node:arraybuffer2ndarray( 'float64', new ArrayBuffer( 0 ), [ 0 ], [ 1 ], 0, 'row-major' )andvector( new ArrayBuffer( 16 ), 16, 'float64' )now return empty arrays. 0-d and negative-stride cases are unchanged.from-arraybuffer, and "the package" vs "the packages" grammar in thedxpbyREADME.tapeis not installed in the review environment.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as part of an automated review of the previous day's commits to
develop.Generated by Claude Code