Skip to content

chore: clean-up - #16436

Merged
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-11-01
Nov 3, 2026
Merged

kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-11-01

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-10-31T19:46:31Z (2f24c6d5d) and 2026-11-01T04:57:50Z (7be647734).

This pull request:

ndarray/from-arraybuffer

  • Fix RangeError: Invalid typed array length: 1 for empty shapes in lib/node_modules/@stdlib/ndarray/from-arraybuffer/lib/main.js (added in 2f24c6d). When numel( shape ) === 0, minmaxViewBufferIndex returns [0,0], yielding N = 1 and an invalid view for new ArrayBuffer( 0 ) or byteOffset === byteLength; N is now ( numel( shape ) === 0 ) ? 0 : idx[ 1 ] - idx[ 0 ] + 1. This restores vector( new ArrayBuffer( 0 ), 'float64' ), which regressed in af38320 when ndarray/vector/ctor switched to this package.
  • Add the missing [@stdlib/array/buffer] link definition in lib/node_modules/@stdlib/ndarray/from-arraybuffer/README.md. The reference is used on lines 25 and 47 but was never defined (2f24c6d). Also remove the unused [@stdlib/ndarray/orders] and [@stdlib/ndarray/index-modes] definitions.

math/base/special/cinv

  • Sync the C usage example in math/base/special/cinv/README.md with examples/c/example.c by changing int main() { to int main( void ) {, following the signature change in 2a22c73.

math/base/special/cinvf

  • Sync the uniform call in math/base/special/cinvf/README.md with examples/index.js, which 8729960 updated to uniform( 200, -100.0, 100.0, { 'dtype': 'float32' } ). Matches csignumf.

Related Issues

Does this pull request have any related issues?

None.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • None. Fixes are scoped to code introduced in the review window.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

  • Reviewed all 34 first-parent commits in the window. Two agents checked stdlib style-guide compliance against reference packages (blas/ext/base/daxpby, stats/base/dists/beta/pdf, math/base/special/cexp), and two agents scanned for bugs. The two bug scanners found the from-arraybuffer empty-shape bug independently.
  • Ran the empty-shape fix with node: arraybuffer2ndarray( 'float64', new ArrayBuffer( 0 ), [ 0 ], [ 1 ], 0, 'row-major' ) and vector( new ArrayBuffer( 16 ), 16, 'float64' ) now return empty arrays. 0-d and negative-stride cases are unchanged.
  • Excluded on purpose: anything that needs interpretation, and anything outside the changed lines. That covers the csignum/csignumf C doc wording, a duplicated test title in from-arraybuffer, and "the package" vs "the packages" grammar in the dxpby README.
  • Not run: the full test suites. tape is not installed in the review environment.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated review of the previous day's commits to develop.



Generated by Claude Code

…rraybuffer`

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD79mcKgFp6uqWTuGTWj
…/special/cinv`

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD79mcKgFp6uqWTuGTWj
…ial/cinvf`

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD79mcKgFp6uqWTuGTWj
@stdlib-bot

stdlib-bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cinv $\\color{red}305/308$
$\\color{green}+0.00\\%$
$\\color{red}12/13$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{red}305/308$
$\\color{green}+0.00\\%$
math/base/special/cinvf $\\color{red}309/312$
$\\color{green}+0.00\\%$
$\\color{red}12/13$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{red}309/312$
$\\color{green}+0.00\\%$
ndarray/from-arraybuffer $\\color{red}309/313$
$\\color{green}+0.01\\%$
$\\color{red}35/38$
$\\color{green}+2.94\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{red}309/313$
$\\color{green}+0.01\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review November 3, 2026 23:16
@kgryte
kgryte requested a review from a team November 3, 2026 23:16
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 3, 2026
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte changed the title fix: address issues in commits merged to develop on 2026-10-31 chore: clean-up Nov 3, 2026
@kgryte
kgryte merged commit d0d8e26 into develop Nov 3, 2026
13 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-11-01 branch November 3, 2026 23:27
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants