Repository navigation
feat: add C implementation for math/base/special/kernel-betaincinv - #13418
Merged
Merged
Conversation
Contributor
Coverage ReportNo coverage information available. |
Planeshifter
marked this pull request as ready for review
July 11, 2026 03:05
This was referenced Aug 26, 2026
Closed
Member
|
@anandkaranubc Would you mind doing a first review of this package? Cheers! |
Contributor
Of course, on it! Thanks! |
6 of 7 tasks
anandkaranubc
force-pushed
the
philipp/kernel-betaincinv-c
branch
2 times, most recently
from
September 26, 2026 23:16
953f5f5 to
765ef04
Compare
anandkaranubc
approved these changes
Sep 26, 2026
anandkaranubc
left a comment
Contributor
There was a problem hiding this comment.
The CI failure is in the downstream stats/base/dists/f/quantile tests, not in this package. The same issue would also show up in stats/base/dists/beta/quantile. Those fixture tolerances were set to the exact worst case of the old JS root-finder, with no headroom. The new root-finder in this PR lands a few ULP away on a handful of large-parameter entries, with no loss of accuracy. Updating those downstream tolerances is a separate change, so I'd prefer to handle it in a follow-up PR.
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: passed
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Planeshifter
force-pushed
the
philipp/kernel-betaincinv-c
branch
from
September 30, 2026 06:22
765ef04 to
9d25801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves stdlib-js/metr-issue-tracker#1322
Description
This pull request:
@stdlib/math/base/special/kernel-betaincinvscripts/evalpoly.jsto generate the C polynomial evaluation functions (spliced intosrc/main.cbetween auto-generated markers), keeping the JS and C polynomial coefficients in sync from a single sourceRelated Issues
This pull request has the following related issues:
math/base/special/betaincinvdepends on this kernel)Questions
No.
Other
Implementation notes:
ibeta_inverse.hpp,t_distribution_inv.hpp, androots.hpp), preserving branch structure, constants, and iteration behavior.@stdlib/math/base/special/betaincdoes not yet have a C implementation, the two call sites in the driver usestdlib_base_kernel_betainc( x, a, b, true, false, &out, &deriv )directly, mirroring what the JSbetaincwrapper does.ldexp( 1.0, (2.0*53.0)/3.0 ); the JSldexptruncates the fractional exponent, so the C port usesstdlib_base_ldexp( 1.0, 35 )to match runtime behavior.@stdlib/math/base/special/kernel-betainc:void stdlib_base_kernel_betaincinv( const double a, const double b, const double p, const double q, double *out1, double *out2 ).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code under my direction, using a multi-agent workflow: the JS implementation and existing C ports (
gammaincinv,kernel-betainc) were studied in detail, the port was generated to mirror the JS line-by-line, and the result was verified via fixture tests, large-scale differential testing against the JS implementation, and multiple independent adversarial review passes. All design decisions and validation results were reviewed by me.@stdlib-js/reviewers