feat(backend): encrypt stored GitHub access tokens - #536
Draft
marcalexiei wants to merge 3 commits into
Draft
marcalexiei wants to merge 3 commits into
marcalexiei wants to merge 3 commits into
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
marcalexiei
marked this pull request as draft
August 28, 2026 12:48
marcalexiei
commented
Aug 28, 2026
martin-mfg
added a commit
that referenced
this pull request
Sep 13, 2026
…d router (#537) The wizard ran the whole `apps/backend` router in the browser. #536 added `node:crypto` to `src/common/database.js`, Vite's browser stub for a Node builtin throws on the first named-export causing e2e tests timeouts. `pg` already needed a `rolldownOptions.external` escape hatch for the same reason. - `src/wizard/renderCard.ts` maps a card URL's pathname to the matching `packages/core` handler and `SvgInline` calls it. `mock-http.ts` and the the `pg` external are removed alongside backend dependency. Resolves the `// will be solved by npm package` https://github.com/stats-organization/github-stats-extended/blob/2e8537db4eb6ce932b8d072f764960e436f612af/apps/frontend/src/wizard/components/Card/SvgInline.tsx#L76-L78 - ~~`e2e/stubCardApi.ts` fulfils the card endpoints, so the `Display` stage's fetch of `https://<host>/api…` no longer logs network errors during e2e.~~ If `process.env.STUB_CARD_API` is set, vite will now serve a stub card. This avoids network error logs during e2e tests without the backend server running. --------- Co-authored-by: martin-mfg <2026226+martin-mfg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Merge this after #537
authenticated_users.access_tokenis AES-256-GCM encrypted whenTOKEN_ENCRYPTION_KEYis set (AccessTokenCipher), withuser_idas AAD;without a key it stays plaintext and a warning is logged on boot.
token: null:/api/user-accessand/api/downgradedrop the row so the user logs in again, cards fall back to the public PAT.A bad key fails on the token paths only, not on import.
TOKEN_ENCRYPTION_KEY=<new>,<old>rotates: first key encrypts, all decrypt.pnpm --filter ./apps/backend run encrypt-access-tokensre-encrypts the rows not yet on the first key, with compare-and-swap, and exits non-zero on unreadable ones or a missing key.