Repository navigation
[6.x] Skip a Stache file that is removed while it is being read - #15903
Open
joshdaugherty wants to merge 1 commit into
Open
joshdaugherty wants to merge 1 commit into
joshdaugherty wants to merge 1 commit into
Conversation
This was referenced Nov 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skips a Stache file that is removed while it is being traversed or read, instead of aborting the traversal or rebuilding the file as a new, empty item.
Traverser::traverse(): ifgetMTime()throws, skip the file only when a freshscandir()shows it is gone; otherwise rethrow.Store::paths(),Store::getItemFromModifiedPath(),BasicStore::getItem()andTaxonomyTermsStore(paths(),getItem(),getItemFromModifiedPath()): whenFile::get()returnsnulland a fresh listing confirms the file is gone, treat it as gone.Tests: a file removed between listing and stat is skipped by the traverser;
paths()skips a path that no longer exists;getItem()returnsnullfor a file removed after its path was recorded. Each fails on6.xwithout the change. The taxonomy term variants share the same guard and have no separate test.Fixes #15902