[6.x] Use the nav item's current tree depth in the page editor - #15425
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Use the nav item's current tree depth in the page editor#15425duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
the editor's `depth` came from the server, which only knows where the item was last saved, so conditions on `depth` were stale after moving an item and missing entirely for new ones. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126fPHSABZ1oDr8eQDQecGc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where field conditions on
depthin the navigation page editor wouldn't reflect an item's current position in the tree until the tree was saved and the page reloaded.This was happening because the page editor's
depthcame from the server, which only knows where the item was last saved. Newly created items didn't get adepthat all.This PR fixes it by having the page tree report each item's current depth and passing that into the page editor, so conditions react to where the item sits right now.
Fixes #11378