[6.x] Flush the file cache after each mounting test - #15387
Merged
Conversation
`MountingTest` switches to the `file` cache driver and only clears it before each test, leaving stale stache entries on disk for later tests that use the same driver. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015MAdoF7RTBQ4mUTaki7k2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where
IncludeNocacheTestandHalfMeasureStaticCachingTestfail with 404s wheneverMountingTestruns earlier in the same process.This was happening because
MountingTestswitches to thefilecache driver and clears it before each test, but never after. Any later test using the file driver then reads the Stache from stale entries on disk, so pages like/aboutdon't exist. Which tests share a process depends on how the shards are split, so this only showed up on the Windows shards of #15385, where adding a test file shiftedMountingTestahead ofIncludeNocacheTest.This PR fixes it by flushing the file store in
MountingTest'stearDown().You can reproduce it on
6.xwith:Related: #15385