Repository navigation
Add a header menu for tablets and phones, and fix the squeezed tournament banner - #42
Merged
Merged
Conversation
…onger gets squeezed On tablets and phones the four links (Games, Tournament, Creators, Docs) were small pills spread across a second row under the logo, which made the header tall and the pills hard to tap. Now, up to 820px wide, the header is one row: the logo on the left, then the dark/light button, the points and the avatar, with a hamburger icon at the right edge. Tapping it opens a small panel with the four links. The panel floats over the page, so nothing below it moves. On phones (600px and under) the dark/light switch moves into the panel as a "Dark mode" row; on tablets it stays in the header. Desktop is unchanged. The hamburger is three lines with a thin outline around the lime middle one, and it turns into an X while the panel is open. Tapping the X, tapping outside the panel, or pressing Escape closes it. Reduced motion is respected. The tournament banner on the homepage had five fixed 96px game tiles, which squeezed the text to a narrow column between 761px and about 900px wide. The tiles now shrink with the screen (60px to 96px), so the text has room.
Header menu for tablets and phones, and a tournament banner that isn't squeezed
Promote dev to main: header menu for tablets and phones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings startnextgen/startng-fe up to date with the Cybertron-HNG fork's main (3 commits, one change).
Frontend only (
src/App.tsx,src/ThemeToggle.tsx,src/styles.css). No new libraries, fonts, colours or breakpoints. It went through a PR into the fork's dev (#112) and then dev into main (#113), with the required checks (Typecheck and build, Worker tests, malware-scan) green on the head commit.