Repository navigation
About page, site footer and a rooms fix - #33
Merged
Merged
Conversation
… doesn't put you back in it
Rooms: cancelling a room nobody has joined closes it, so Find a match doesn't put you back in it
…; removes "Built by the HNG community" Shop, spotlight and creator hub pages use the same footer function.
feat: proper site footer on server-written pages
- /about is listed in the sitemap - the homepage text's About block ends with 'More about start.ng →', as the app's does - the indie pages test checks game guide pages only (the site's own /about is in the sitemap now) (cherry picked from commit e62af2aa523ee642528e4e8f0f5d01f11707cb27)
Add /about to the sitemap; the homepage About and the footer link to it
Merge dev into main: site footer and the About page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings startnextgen/startng-be up to date with the Cybertron-HNG fork's main (4 commits). Each change went through a PR into the fork's dev with pytest and malware-scan green, then dev into main (#141) with CodeQL, Analyze and the dependency checks green as well.
/aboutis in the sitemap, and the homepage text's About block ends with "More about start.ng →", as the app's does./about.To deploy: no settings, no migrations. Deploy together with startnextgen/startng-fe, which has the About page and the matching footer.
Checks run locally on dev (the exact code in this PR): pytest 1003 passed, 2 skipped.