Repository navigation
Rooms rematch and chess, game page design, fewer category chips - #32
Merged
Merged
Conversation
…n, check, mate, stalemate, draws) and a bot
Rooms: rematch after a game ends, in the same room, with the other player going first
# Conflicts: # app/features/rooms/tests/test_rooms.py
Rooms: chess, with our own rules code and a bot
Web games, Browser games, Free online games and HTML5 games are on every game, so they are no longer chips on a game's page (their own pages stay, and stay on the categories hub).
… cover, tabs, facts, cards, key caps and questions that open Same words and same markup for search engines (headings, FAQ and HowTo data); only the wrapping changes.
feat: game pages show only the categories that tell a game apart
feat: game details pages: hero, tabs, facts, cards, key caps, FAQ that opens
Merge dev into main: room rematch and chess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings startnextgen/startng-be up to date with the Cybertron-HNG fork's main (10 commits). Each change went through a PR into the fork's dev with pytest and malware-scan green, then dev into main (#136) with CodeQL, Analyze and the dependency checks green as well.
roomsis inFEATURES.To deploy: no new settings and no migrations. Deploy together with startnextgen/startng-fe: the game pages' new markup looks unstyled without the matching styles, and the rematch button is ignored until this is live.
Checks run locally on dev (the exact code in this PR): pytest 1000 passed, 2 skipped.