Repository navigation
fix(ci): restore workspace installs and isolate Windows process tests - #94
Conversation
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable issue remains from this review; the change is mergeable after normal checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 7 files. (3 skipped: 3… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check 标题准确概括了主要变更：恢复跨平台工作区安装，并隔离 Windows 进程测试。内容具体、简洁，与变更集直接相关。 Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 7 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 2
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d8b7c096d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fead3bf96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const shortcutPath = path.join(programsDir, `beautiCode ${NAMES[host]} (背景).lnk`); | ||
| // WScript shortcut persistence can reject Unicode filenames on an English Windows image. | ||
| // Use a private ASCII alias for COM reads/writes; the filesystem publishes the unchanged display name without overwrite. | ||
| const temporaryPath = path.join(programsDir, `.beauticode-${randomUUID()}.lnk`); |
There was a problem hiding this comment.
When %APPDATA% or the Windows profile directory contains non-ASCII characters, joining the ASCII basename to programsDir still produces a non-ASCII full path. The new fixture in quick-shortcuts.test.mjs models COM failure for any non-ASCII character in FullName, so in that same environment CreateShortcut($temporaryPath) still fails and the shortcut cannot be created or inspected. Use a guaranteed ASCII/short path for the alias's entire path, not only its basename.
Useful? React with 👍 / 👎.
主分支 CI 在 Ubuntu 的 npm ci 阶段因 Windows 专用工作区声明触发 EBADPLATFORM，Windows 的快捷方式测试则仅报告被截断的 PowerShell CLIXML。此前同一提交的不同检查还出现 DSH 活动目录替换竞态和 Windows 子进程超时。
本次让源码工作区支持跨平台依赖安装，并由聚合打包器给正式产物保留 os: ["win32"]；Desktop 测试统一使用现有长路径临时目录运行器，并串行执行测试文件。快捷方式调用禁用进度输出、使用文本格式和有界缓冲，优先报告实际进程错误码。DSH 监视器在用户事务期间停止读取活动清单，避免初始化逻辑在原子目录替换中重建目标目录。
验证：
失败基线：https://github.com/starsstreaming/beautiCode/actions/runs/38132448422 。设计及回滚边界记录在 docs/adr/0008-ci-workspace-and-windows-test-isolation.md。本次不修改 CLI 功能、包版本，不发布 npm，也不操作本机宿主配置。
Summary by CodeRabbit