Fix: issue 2030 - IllegalArgumentException when using findAndRerank without specifying rerankOn - #2578
Open
sl-at-ibm wants to merge 3 commits into
Open
Fix: issue 2030 - IllegalArgumentException when using findAndRerank without specifying rerankOn#2578sl-at-ibm wants to merge 3 commits into
sl-at-ibm wants to merge 3 commits into
Conversation
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Until now, there are conditions where a call to
findAndRerankwithout supplyingrerankOnresults in a naked "unexpected server error" / "illegal argument exception". This PR replaces those with a clean error belonging to theerrors.yamltaxonomy.Which issue(s) this PR fixes:
Fixes #2030.
Checklist