Fix 'workflow not found' when the chat assistant creates a workflow - #12
Merged
Merged
Conversation
The chat UI selected the new workflow on the tool-call event, which fires before the tool executes, so the sidebar refresh and flow fetch raced the publish and 404'd. Move it to the tool-result event, gate on ok, and use the final (possibly collision-renamed) name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ChatFlyoutnow callsonWorkflowCreatedfromonToolResultinstead ofonToolCall. It only fires whencreate_workflowsucceeds (output.ok), and it passes the name the server returns (output.name).Why
When the assistant created a workflow, the UI showed "workflow not found" until the page was refreshed. The
tool-inputevent fires before the tool runs, so the sidebar refresh andgetWorkflowFlowfetch happened before the workflow existed and got a 404. That setloadError.This also fixes two related problems:
create_workflowmay save under a different one, and the old code selected the requested name.Reviewer notes
run_workflowalready uses in the same handler.node_modules.