Repository navigation
Description
Follow-up to #1518. These came up while fixing that issue in #1646 and during its review. None of them are fixed by #1646. Each item is a separate fix, and anyone is welcome to pick one up.
Medium
- While an update is
InProgress(with--async-settle), Invoke runs the new code. Real Lambda keeps serving the previous code and configuration until the update completes (Lambda function states). Today the new code is live as soon as UpdateFunctionCode returns (providers/aws/lambda/lambda.go, invoke path).
Low
- A version created by
UpdateFunctionCode --publishreportsActive/Successfulright away instead of following the update'sInProgresswindow. Check what real Lambda reports for that version while the update is still running. - DeleteAlias on a missing alias returns
ResourceNotFoundException(providers/aws/lambda/aliases.go), but the DeleteAlias API reference does not list that error. Real Lambda may treat it as a no-op success. Verify against real AWS. - Not-found message text for UpdateAlias, DeleteAlias and
DeleteFunction --qualifier(function version %s not foundinversions.go) is emulator wording. GetAlias was converted to the realCannot find alias arn: ...text in fix(aws-lambda): version immutability, async state, LogType=Tail, GetAccountSettings, code signing configs (#1518) #1646; the rest need real-AWS text before changing. - The version
UpdateFunctionCode --publishcuts reportsPending(reasonCreating) while the update isInProgress(with--async-settle), but invoking that version still works and runs the new code. The Lambda function states page says a Pending function can't be invoked. Check what real Lambda returns when you invoke a Pending version and match it (providers/aws/lambda/lambda.go, invoke path).
How to work on an item
1. Claim it. Comment here with the item you're picking up, so two people don't fix the same thing. Small PRs are easier to review, so take one item, or a few that share a root cause.
2. Find out what real AWS does. Read the AWS API reference for the operation, and if you can, check the real CLI or SDK. Match the real error code, HTTP status and message. Don't guess them. Put the doc link in your PR.
3. Branch from development. All PRs go to development, never main.
4. Put the fix in the right layer. cloudemu has three layers, and the same behaviour has to work from the Go library and from cloudemu serve:
services/<service>/driver/driver.goholds the driver interface. Touch it only when you add a new operation or field.providers/aws/<service>/is the in-memory backend, and this is where most fixes belong: validation, state changes, lifecycle and error codes. Usememstore.Store,idgenfor IDs,cerrorsfor errors andconfig.FakeClockfor anything time-based.server/aws/<service>/is the wire handler. It only translates the AWS protocol (query/XML, JSON or REST) to provider calls and maps errors back to the AWS shape. Don't put business rules here, or the library and the server will drift apart.- If you add new state, make sure it survives
cloudemu serve --persistand snapshots.persist/completeness_test.gowill tell you if you missed something. - If you add or change operations, run
go generate ./...sodocs/coveragestays current, and commit the result.
See docs/architecture.md and docs/STRUCTURE.md for the layout and file naming.
5. Test it the way a user would.
- A provider test that fails before your fix and passes after it.
- A wire test that drives the handler with the real
aws-sdk-go-v2client, like the existing*_sdk_test.gofiles. - Run
cloudemu serveand try the change with the AWS CLI (aws --endpoint-url http://127.0.0.1:4566 ...), including the error cases. - If Terraform has a resource for it, run
apply, thenplan(it should show no changes), thendestroy.
6. Run the checks before you push. go build ./..., go vet and go test on the packages you touched (the full go test ./... if you can), and golangci-lint run --timeout=9m ./... with zero issues.
7. Open the PR. Say which item it fixes, what changed and why, and how you checked it (paste the CLI commands you ran). Add "Part of #1665" so we can tick the box here once it's merged. See CONTRIBUTING.md for setup and code style.
Activity
fix(aws-lambda): match real not-found behaviour for DeleteAlias, Upda…
fix(aws-lambda): keep serving the previous revision while an update i…