chore: Describe RBAC rules, remove unnecessary rules#1020
Merged
NickLarsenNZ merged 12 commits intomainfrom Apr 9, 2026
Merged
chore: Describe RBAC rules, remove unnecessary rules#1020NickLarsenNZ merged 12 commits intomainfrom
NickLarsenNZ merged 12 commits intomainfrom
Conversation
18 tasks
NickLarsenNZ
commented
Apr 2, 2026
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
…clusterrole It is not needed for CRD maintenance nor startup condition
… product clusterrole Any necessary configmaps/secrets would be mounted. The product pod doesn't communicate with the Kubernetes API
The operator manages events
…tor.yaml and clusterrole-product.yaml
Member
Author
|
Techassi
previously approved these changes
Apr 9, 2026
deploy/helm/zookeeper-operator/templates/clusterrole-operator.yaml
Outdated
Show resolved
Hide resolved
…yaml Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>
Techassi
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#798
Note
This was initially generated by a coding assistant to see how well it can inspect code and review the RBAC rules. the changes will be properly checked before reviews are requested.
Operator ClusterRole
nodeslist/watch - not needed; onlynodes/proxyget is required (for cluster domain detection)podsget/list/create/delete/patch/update/watch - operator does not manage Pod objects directly (StatefulSets handle that)secretsget/list/create/delete/patch/update/watch - operator does not create or manage Secretsendpointsget/list/create/delete/patch/update/watch - operator does not manage Endpointsbatch/jobsget/list/create/delete/patch/update/watch - operator does not create Jobsupdateverb on configmaps, services, serviceaccounts, rolebindings, statefulsets, poddisruptionbudgets - not needed; the operator uses Server-Side Apply (patch), not updatewatchverb on rolebindings, poddisruptionbudgets - operator does not watch these resourcesgetverb on customresourcedefinitions - not needed; operator only needs list/watch (startup condition) and create/patch (CRD maintenance)watchverb on listeners - operator does not watch Listener objectsProduct ClusterRole
configmaps/secrets/serviceaccountsget - ZooKeeper pods do not read these via the Kubernetes API; configuration is mounted into the container by the kubeletevents.k8s.io/eventscreate/patch - ZooKeeper pods do not emit Kubernetes events