Skip to content

feat: Add startup probe to operator deployment #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xeniape wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add startup probe to operator deployment #654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
972f0fb
feat: Add startup probe to operator deployment
xeniape Oct 1, 2026
7e8bee7
Adjust periodSeconds in probe
xeniape Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions template/deploy/helm/[[operator]]/templates/deployment.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ spec:
- name: OPA_BUNDLE_BUILDER_CLUSTERROLE
value: {{ include "{[ operator.name }].fullname" . }}-opa-bundle-builder-clusterrole
{[% endif %}]
startupProbe:
httpGet:
path: /ready
port: 8443
Comment thread
sbernauer marked this conversation as resolved.
scheme: HTTPS
periodSeconds: 3
failureThreshold: 30
timeoutSeconds: 3

@sbernauer sbernauer Oct 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It felt weird to have timeout > period, so I asked AI:

timeoutSeconds (3) is larger than periodSeconds (2). The kubelet doesn't run probes in parallel, so nothing breaks, but probes that time out end up running back-to-back every ~3 s. Your startup budget then varies between 60 s (fast failures like connection refused) and about 90 s (timeouts), which makes the config harder to reason about. Keep timeout ≤ period. For example, periodSeconds: 3, timeoutSeconds: 3, failureThreshold: 20 gives a clean 60 s.

And I fully agree with it

@xeniape xeniape Oct 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with increasing periodSeconds to 3. The only advantage of that configuration, I guess, was that it would become ready faster if CRDs were there while also giving some more time to the kubelet in case of timeouts/something hangs.

@sbernauer sbernauer Oct 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Having both at 2s also works for me, I let you decide

@xeniape xeniape Oct 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7e8bee7

{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down
Loading