Repository navigation
Conversation
Techassi
requested changes
Sep 25, 2026
Techassi
left a comment
Techassi
left a comment
Member
There was a problem hiding this comment.
This seems fully LLM generated and it shows.
There are just plain wrong statements, a whole bunch of unnecessary fluff, statements about well-known facts, and duplication.
In my opinion, this needs a bunch of work. I could point out all things I didn't like, but that's something I don't want to invest time for. I'm not here to review LLM-generated stuff.
I still left a few comments.
Member
Author
|
Yeah, as I said in the Issue is only here to give the idea of what I want to do. It was never meant to be completed as is. Thank you for your review however. Would you be happy on how configs are split across repositories? |
…ackabletech/operator-templating into feat/enable-crate-typos-on-ci
Techassi
requested changes
Oct 2, 2026
Techassi
changed the title
xeniape
requested changes
Oct 6, 2026
…ackabletech/operator-templating into feat/enable-crate-typos-on-ci
Co-authored-by: Xenia <xeniafischer@hotmail.de>
xeniape
requested changes
Oct 6, 2026
xeniape
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1 of https://github.com/stackabletech/retro/issues/36
-> Currently a suggestion on how to approach this
Trino-Operator spike: stackabletech/trino-operator#942
docker-images spike: stackabletech/docker-images#1634