Repository navigation
chore: Remove unused RBAC permission for product role - #774
Merged
Merged
Conversation
18 tasks
razvan
reviewed
Apr 10, 2026
razvan
left a comment
razvan
left a comment
Member
There was a problem hiding this comment.
maybe also update the pr list in the changelog ?
Member
Author
Oops, yeah I had that sitting here locally. |
NickLarsenNZ
enabled auto-merge
April 10, 2026 12:13
sbernauer
moved this from Development: Waiting for Review
to Development: Track
in Stackable Engineering
sbernauer
moved this from Development: Track
to Development: Done
in Stackable Engineering
lfrancke
moved this from Development: Done
to Acceptance: In Progress
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#798
Follow up of https://github.com/stackabletech/airflow-operator/pull/767/changes#r3014650545
Details
The events rule in the product ClusterRole (lines 31-38) looks safe to remove. Here's why:
create_namespaced_eventor usesEventsV1Apito create Event objects.KubernetesPodOperatorcan read events for failed pods viaCoreV1Api.list_namespaced_event(core""API group, notevents.k8s.io), and even that is off by default in the official Airflow Helm chart.clusterrole-operator.yaml), but the workload pods don't.get/liston core API events, and makes even that optional (rbac.events = falseby default).