Fix hreflang validation for links and assets - #4
Merged
m-mohr merged 4 commits intoAug 27, 2026
Conversation
yharby
marked this pull request as ready for review
August 25, 2026 05:52
Contributor
|
Thanks, I'd like to cherry-pick the JSON Schema changes into 1.0.0 so that we can fix the schema without requiring a new release. And then merge the rest in. |
yharby
force-pushed
the
fix/hreflang-schema-validation
branch
from
August 25, 2026 05:59
31c7144 to
284ed6d
Compare
Contributor
Author
|
Thanks, Can you check now ? |
Contributor
|
Thanks, cherry-picked the schema into 1.0.0 release so that we don't need to rerelease just for that. Otherwise, merged everything else in for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
$refskeys with$ref.hreflangvalues on links and assets.Commit split
59d05d5changes onlyjson-schema/schema.json. It is ready to cherry-pick into v1.0.0.284ed6dadds the tests, STAC 1.1.0 examples, package change, and changelog entry.Why
JSON Schema ignores the unknown
$refskeyword.An invalid
hreflangvalue could pass validation on a link or asset.Fixes #3.
Verification
The command used the six examples in
examples/. It fetched the official STAC 1.1.0 schemas.