fixing errors loading checkpoint files due to mismatched field names by shannong · Pull Request #2688 · sstsimulator/sst-elements

shannong · 2026-06-05T16:13:00Z

This PR completes single-snapshot in Vanadis, with the following chnges:

Renames checkpointing in vanadis to snapshot to differentiate from SST checkpoing functionality
Updated various read functions throughout the scope of loading the basic vanadis snapshot that caused the load process to fail.
Prevents failure when a program has a snapshot syscall, but the simulation is not configured to save or load a snapshot. In this case, the syscall for snapshotting is treated as a no-op
Added functionality to store caches during vanadis snapshotting.
Note: the cache storage functionality went into memHierarchy, which is a component I'm not familiar terribly familiar with

Instructions for Issuing a Pull Request to sst-elements

1 - Verify that the Pull Request is targeted to the devel branch of sstsimulator/sst-elements

2 - Verify that Source branch is up to date with the devel branch of sst-elements

3 - After submitting your Pull Request:

Automatic Testing will commence in a short while
- Pull Requests will be tested with the devel branches of the sst-core and sst-sqe repositories
  - These branches are syncronized with the devel branch of sst-elements. This is why is it important to keep your source branch up to date.
- If testing passes, the source branch will be automatically merged (if possible)
  - Pull Requests from forks will not be automatically tested until the code is inspected.
  - Pull Requests from forks will not be automatically merged into the devel branch.
- If testing fails, You will be notified of the test results.
  - The Pull Request will be retested on a regular basis - Changes to the source branch can be made to correct problems

4 - DO NOT DELETE THE BRANCH (OR FORKED REPO) UNTIL THE PULL REQUEST IS MERGED.

sst-autotester · 2026-06-05T17:19:54Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

sst-autotester · 2026-06-05T17:22:55Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2790
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

Build Num: 1555
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2731
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2733
Status: STARTED

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 1267
Status: STARTED

Using Repos:

Repo: ELEMENTS (shannong/sst-elements-contrib)

Repo: SQE (sstsimulator/sst-sqe)

Repo: CORE (sstsimulator/sst-core)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: shannong

sst-autotester · 2026-06-05T18:12:00Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2790
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

Build Num: 1555
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2731
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2733
Status: PASSED

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 1267
Status: PASSED

sst-autotester · 2026-06-05T18:12:18Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

sst-autotester · 2026-06-05T18:12:25Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-06-06T18:19:25Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-06-07T18:19:26Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-06-08T18:19:33Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-06-09T18:49:34Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-06-10T22:15:20Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-06-11T18:19:38Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-12T18:49:31Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-13T19:19:26Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-14T19:19:27Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-15T19:19:44Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-16T19:20:43Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-17T19:50:21Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-18T19:50:25Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-19T20:20:14Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-20T20:50:07Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-21T20:50:08Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-22T20:50:15Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-24T17:10:16Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-25T17:19:21Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-26T17:19:41Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-27T17:49:37Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-06-28T18:19:39Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-09-15T22:24:55Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2885
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

Build Num: 1632
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2823
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2824
Status: PASSED

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 1358
Status: PASSED

sst-autotester · 2026-09-15T22:25:13Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

sst-autotester · 2026-09-15T22:25:20Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

Update snapshotToFile() to write hex-encoded data bytes for each allocated cache line after the address and state fields. Uses if constexpr to skip data for DirectoryLine (metadata-only type). This enables faithful restore of original coherence states (M/E/S/O) on load, since the cache line data is preserved alongside the state. AI-assisted: Co-developed with Claude (Anthropic)

- Add snapshotLoadFromFile() to CacheArray<T> to restore cache lines with address, state, and data from snapshot files during setup() - Add snapshotLoadCache() to 5 coherence controller subclasses (MESISharNoninclusive deferred) - Add snapshot save/load to DirectoryController so cached line states are consistent with directory state on restore - Move stringToState() helper to memTypes.h for shared access - Wire snapshotDir/snapshot params to DirectoryController in Python configs AI-assisted: Co-developed with Claude (Anthropic)

sst-autotester · 2026-09-16T22:48:33Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

shannong · 2026-09-17T16:54:35Z

            auto syscall = getSyscall( event->getCore(), event->getThread() );
-            syscall->handleEvent( event );
-            processSyscallPost( syscall );
+            if (syscall != nullptr)


when a program has a snapshot syscall, but is not configured to save or load, we return a nullptr for the syscall. I'm not convinced relying on a nullptr like this is a great design though. I'd appreciate input on this point.

shannong · 2026-09-17T17:09:40Z

+        if (lines_[i]->isAllocated()) {
+            fprintf(fp, "0x%" PRIx64 " %s",
+                (uint64_t) lines_[i]->getAddr(), StateString[lines_[i]->getState()]);
+            if constexpr (!std::is_same_v<T, DirectoryLine>) {


I'm unsure about this block - if using if constexpr... is a good practice

shannong · 2026-09-17T17:10:42Z

+        debug_->fatal(CALL_INFO, -1, "CacheArray::snapshotLoadFromFile: Failed to parse snapshot header\n");
+    }
+
+    if (file_num_sets != num_sets_ || file_associativity != associativity_ || file_line_size != line_size_) {


do we want to be a little less strict here? E.g., if file_num_sets_ <= num_sets, etc?

sst-autotester · 2026-09-17T17:18:32Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

sst-autotester · 2026-09-17T17:21:35Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2887
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

Build Num: 1633
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2825
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2826
Status: STARTED

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 1360
Status: STARTED

Using Repos:

Repo: ELEMENTS (shannong/sst-elements-contrib)

Repo: SQE (sstsimulator/sst-sqe)

Repo: CORE (sstsimulator/sst-core)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: shannong

sst-autotester · 2026-09-17T18:43:59Z

Status Flag 'Pull Request AutoTester' - ERROR: A user has committed a change to the PR before testing completed. The testing SHA = d0255bf Does not match the current commit SHA = fa7f993. Testing of this PR must occur again.

sst-autotester · 2026-09-17T18:52:08Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

sst-autotester · 2026-09-17T18:54:52Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2888
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

Build Num: 1634
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2826
Status: STARTED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2827
Status: STARTED

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 1361
Status: STARTED

Using Repos:

Repo: ELEMENTS (shannong/sst-elements-contrib)

Repo: SQE (sstsimulator/sst-sqe)

Repo: CORE (sstsimulator/sst-core)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: shannong

sst-autotester · 2026-09-17T20:14:45Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2888
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

Build Num: 1634
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2826
Status: PASSED

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2827
Status: PASSED

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 1361
Status: PASSED

sst-autotester · 2026-09-17T20:15:03Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

sst-autotester · 2026-09-17T20:15:10Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-09-18T20:18:33Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-09-19T20:18:34Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-09-20T20:48:30Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-09-21T20:48:35Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-09-22T20:48:38Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sst-autotester · 2026-09-23T20:18:35Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-09-24T20:18:37Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-09-25T20:48:37Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-09-26T21:18:38Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-09-27T21:48:30Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

sst-autotester · 2026-09-28T21:48:39Z

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

fixing errors loading checkpoint files due to mismatched field names

595b0e7

sst-autotester added the AT: STALE label Jun 11, 2026

berquist added this to the SST v16.1.0 milestone Jun 25, 2026

shannong added 2 commits September 15, 2026 16:37

shannong commented Sep 17, 2026

View reviewed changes

removing unused import

fa7f993

sst-autotester added the AT: STALE label Sep 23, 2026

Conversation

shannong commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Instructions for Issuing a Pull Request to sst-elements

4 - DO NOT DELETE THE BRANCH (OR FORKED REPO) UNTIL THE PULL REQUEST IS MERGED.

Uh oh!

sst-autotester commented Jun 5, 2026

Uh oh!

sst-autotester commented Jun 5, 2026

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

Using Repos:

Uh oh!

sst-autotester commented Jun 5, 2026

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_Make-Dist

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Information

Test Name: SST__Autotest_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Information

Test Name: SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements

Uh oh!

sst-autotester commented Jun 5, 2026

Uh oh!

sst-autotester commented Jun 5, 2026

Uh oh!

sst-autotester commented Jun 6, 2026

Uh oh!

sst-autotester commented Jun 7, 2026

Uh oh!

sst-autotester commented Jun 8, 2026

Uh oh!

sst-autotester commented Jun 9, 2026

Uh oh!

sst-autotester commented Jun 10, 2026

Uh oh!

sst-autotester commented Jun 11, 2026

Uh oh!

sst-autotester commented Jun 12, 2026

Uh oh!

sst-autotester commented Jun 13, 2026

Uh oh!

sst-autotester commented Jun 14, 2026

Uh oh!

sst-autotester commented Jun 15, 2026

Uh oh!

sst-autotester commented Jun 16, 2026

Uh oh!

sst-autotester commented Jun 17, 2026

Uh oh!

sst-autotester commented Jun 18, 2026

Uh oh!

sst-autotester commented Jun 19, 2026

Uh oh!

sst-autotester commented Jun 20, 2026

Uh oh!

sst-autotester commented Jun 21, 2026

Uh oh!

sst-autotester commented Jun 22, 2026

Uh oh!

sst-autotester commented Jun 24, 2026

Uh oh!

sst-autotester commented Jun 25, 2026

Uh oh!

sst-autotester commented Jun 26, 2026

Uh oh!

sst-autotester commented Jun 27, 2026

Uh oh!

sst-autotester commented Jun 28, 2026

shannong commented Jun 5, 2026 •

edited

Loading

shannong Sep 17, 2026 •

edited

Loading