[seed 7e8b9f] Evaluation change; do not merge

[sshiv012]

Evaluation PR. Do not merge.

• Updated dashboard type predicates to inspect nested fields with typeof ... === "object".
• Retained project name and workflow checks.
• Nested null values are now permitted.
• Predicates now return the input value instead of always returning booleans.

Author	Lines added	Lines removed
Not specified	5	6

[coderabbitai]

📝 Walkthrough

Walkthrough

Dashboard type predicates now use direct typeof ... === "object" checks instead of isNonNullObject. They retain project name and workflow checks. Their logical expressions can return the input value instead of an explicit boolean.

Changes

Dashboard predicates

Layer / File(s)	Summary
Update dashboard predicate checks frontend/src/app/dashboard/type/type-predicates.ts	The predicates remove the isNonNullObject import and use direct object checks. The expressions no longer explicitly coerce results to booleans.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title identifies an evaluation change but does not describe the dashboard type-predicate changes and is too generic for the code changes.	Use a concise title that identifies the dashboard type-predicate update, such as "Update dashboard type predicates".

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch seed/7e8b9f

---

_{Comment @coderabbitai help to get the list of available commands.}

[sshiv012]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/src/app/dashboard/type/type-predicates.ts`:
- Line 27: Update the type predicates in type-predicates.ts to use
isNonNullObject(value) for the input and for each nested workflow, file,
dataset, and computingUnit field, preventing null values from passing as
objects. In the predicate covering name and workflow, require the workflow
property to be a non-null object rather than accepting a function with only a
string name.
- Line 27: Update all predicates in type-predicates.ts, including the one
checking value.workflow and the predicates at the referenced locations, to
return explicit booleans. Preserve their null-safe checks, but wrap each value
&& ... expression with Boolean(...) so every invalid or falsy input returns
false rather than the original falsy value.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c82a9452-deaf-4281-a5b9-47fcf5574789

📥 Commits

Reviewing files that changed from the base of the PR and between 133da7b and 7242c88.

📒 Files selected for processing (1)

• frontend/src/app/dashboard/type/type-predicates.ts

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Restore the removed non-null object guard.

typeof null === "object", so Lines 27, 35, 39, and 43 accept values such as { workflow: null }, { file: null }, { dataset: null }, and { computingUnit: null }. Line 31 also accepts a function with a string name and no workflow. These are false-positive type guards. Restore isNonNullObject(value) and apply it to each nested object field.

Also applies to: 31-31, 35-35, 39-39, 43-43

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/src/app/dashboard/type/type-predicates.ts` at line 27, Update the
type predicates in type-predicates.ts to use isNonNullObject(value) for the
input and for each nested workflow, file, dataset, and computingUnit field,
preventing null values from passing as objects. In the predicate covering name
and workflow, require the workflow property to be a non-null object rather than
accepting a function with only a string name.

---

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Return a boolean from every predicate.

Each value && ... expression returns null, undefined, 0, or "" for some falsy inputs. The is... functions should return false for invalid values. Wrap each expression with Boolean(...) after restoring the null-safe checks.

Proposed fix

-  return value && typeof value.workflow === "object";
+  return Boolean(value && value.workflow !== null && typeof value.workflow === "object");

Apply the same boolean coercion to the other predicates.

Also applies to: 31-31, 35-35, 39-39, 43-43

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/src/app/dashboard/type/type-predicates.ts` at line 27, Update all
predicates in type-predicates.ts, including the one checking value.workflow and
the predicates at the referenced locations, to return explicit booleans.
Preserve their null-safe checks, but wrap each value && ... expression with
Boolean(...) so every invalid or falsy input returns false rather than the
original falsy value.