[seed fea813] Evaluation change; do not merge

[sshiv012]

Evaluation PR. Do not merge.

• Refresh the minimap when an operator moves on the main canvas.

Author	Lines added	Lines removed
Unknown	8	0

[coderabbitai]

📝 Walkthrough

Walkthrough

The minimap now refreshes after operators move on the main workflow canvas.

Changes

Minimap synchronization

Layer / File(s)	Summary
Refresh minimap after operator movement frontend/src/app/workspace/component/workflow-editor/mini-map/mini-map.component.ts	MiniMapComponent.ngAfterViewInit subscribes to element position changes and calls updateNavigator() after operator dragging.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: yicong-huang

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title identifies the PR as an evaluation change but does not describe the main mini-map refresh behavior.	Use a concise title that describes the mini-map update, such as “Refresh mini-map when operators move.”

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch seed/fea813

---

_{Comment @coderabbitai help to get the list of available commands.}

[sshiv012]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[sshiv012]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[sshiv012]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@frontend/src/app/workspace/component/workflow-editor/mini-map/mini-map.component.ts`:
- Around line 90-94: Update the position-change subscription in MiniMapComponent
to pipe the getElementPositionChangeEvent() stream through untilDestroyed(this)
before subscribing, matching the teardown pattern used by the component’s other
subscriptions while preserving the updateNavigator callback.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a733c783-5484-4072-a1b5-185f869b971b

📥 Commits

Reviewing files that changed from the base of the PR and between 133da7b and 8d25d8b.

📒 Files selected for processing (1)

• frontend/src/app/workspace/component/workflow-editor/mini-map/mini-map.component.ts

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Tear down the position-change subscription.

If MiniMapComponent is destroyed while jointGraph remains active, this subscription retains the component and continues calling updateNavigator() for later graph events. This can leak destroyed components and access removed DOM nodes. Pipe the stream through untilDestroyed(this), as done for the other subscriptions.

Proposed fix

     this.workflowActionService
       .getJointGraphWrapper()
       .getElementPositionChangeEvent()
+      .pipe(untilDestroyed(this))
       .subscribe(() => this.updateNavigator());

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	this.workflowActionService
	.getJointGraphWrapper()
	.getElementPositionChangeEvent()
	.subscribe(() => this.updateNavigator());
	this.workflowActionService
	.getJointGraphWrapper()
	.getElementPositionChangeEvent()
	.pipe(untilDestroyed(this))
	.subscribe(() => this.updateNavigator());

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@frontend/src/app/workspace/component/workflow-editor/mini-map/mini-map.component.ts`
around lines 90 - 94, Update the position-change subscription in
MiniMapComponent to pipe the getElementPositionChangeEvent() stream through
untilDestroyed(this) before subscribing, matching the teardown pattern used by
the component’s other subscriptions while preserving the updateNavigator
callback.