[replay #7509] test(frontend): cover the joint graph wrapper's layout and co-editor paths - #15
[replay #7509] test(frontend): cover the joint graph wrapper's layout and co-editor paths#15sshiv012 wants to merge 2 commits into
Conversation
…paths joint-graph-wrapper.ts sat at 76.4% lines and 50.6% branches - the branch figure being the real gap, since a line counts as covered with one side of its condition never taken. Adds 20 tests covering absolute positioning, the link cell change stream, auto layout, the co-editor presence rings and their re-padding on delete, the editing banner, and the guard clauses for missing and wrong-typed cells. Lines go to 97.91% and branches to 96.47%. Everything runs under jsdom with no extra infrastructure: a real joint.dia.Paper constructs and renders, findViewByModel returns a real view, the mask highlighters apply, and DirectedGraph.layout runs. No production file is touched.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test suite expands coverage for ChangesJoint graph wrapper test coverage
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Replay of apache#7509 for CodeRabbit evaluation.
merge-base
42d08a3701cdhead3dd6d7be933astratumfrontendSynthetic evaluation PR. Do not merge.
joint-graph-wrapper.JointUIServiceimports for co-editor CSS class constants.