Repository navigation
feat(planner): default stable releases to Energyplan - #1529
Conversation
EngineForBuild picked Energyplan only for vX.Y.Z-beta.N. A stable vX.Y.Z build fell back to Core DP when planner.engine was unset, so a beta box moving to the first native stable would switch planner without notice. Match both beta and stable release tags; development builds and unsupported hosts keep Core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9be07c3330
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Beta and stable releases default to the bundled Energyplan worker on a | ||
| // supported host; development builds default to Core. |
There was a problem hiding this comment.
Update the remaining docs for the stable default
This stable-default change leaves go/internal/config/config.go:693 saying an unset engine uses Energyplan only in betas, while optimizer/native/README.md:53-56 still explicitly says stable builds default to Core. Maintainers following either description can unintentionally select Energyplan on a stable Linux installation, so both references should be updated with the other documentation in this commit.
AGENTS.md reference: AGENTS.md:L274-L275
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
config.Planner.EngineForBuildchose Energyplan only when the version matchedvX.Y.Z-beta.N. A stable build (vX.Y.Z) with noplanner.enginefell back to Core DP. Every beta tester runs Energyplan by default, so promoting a beta to the first native stable would switch each of them to another planner without notice. The home box has no explicit engine and would have switched.Decision
The owner chose on 2026-10-07: stable uses Energyplan by default, the same as beta. Core DP still runs as the bounded shadow and fallback, Core still validates every plan, and
planner.engine: corestill selects Core DP.Change
planner_engine.go: match release tags with or without-beta.N. Development builds (v0.X.Y-dev.<hash>,dev), release candidates and non-Linux or 32-bit hosts keep Core.coreon stable gives Core, and a dev-hash build gives Core. The batteryless admission test now expects Energyplan for the stable default on supported hosts.config.example.yamlanddocs/architecture.mdnow say beta and stable.The forecast pipeline was already the same for every channel (
energyplanSupportedonly), so nothing else needed to change.Tests
go test ./internal/config -run TestPlannerEngineForBuild, andgo test ./cmd/ftw -run 'TestEnergyplanReleaseSelection|TestBuildMPC…'pass on macOS. The bundled-worker wiring test skips on macOS and runs in Linux CI.go vetis clean.Open PRs #1051 and #1292 touch other sections of
docs/architecture.md, and #1003 touches another section ofconfig.example.yaml. This PR edits only the planner lines.Release
This goes in the same beta as #1528, and that beta is the stable candidate.
🤖 Generated with Claude Code