Conversation
Contributor
Author
|
Closing as superseded by #1503. Hardware validation of #1503 on ARM64 confirmed that MyUplink Test connection works directly with the installed driver's persisted OAuth state, including after reloading the web UI, without clicking Connect to MyUplink or signing in again. Two independent test probes reached The UI workaround in this PR is therefore not needed for the reported problem; the backend persisted-secret fix in #1503 addresses the root cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Test connection do the useful next step for a MyUplink driver that has not completed OAuth yet. Instead of launching a probe that is guaranteed to fail without a refresh token, the UI now starts the existing Connect to MyUplink authorization flow and explains that sign-in is required. Once OAuth has completed, Test connection continues to use the normal live driver probe.
Hardware observation
On a real ARM64 FTW installation, MyUplink Test connection failed before Connect to MyUplink + sign-in, then succeeded after OAuth completed. This change makes that dependency explicit and actionable.
Scope
UI-only behavior change; OAuth endpoints and driver authentication are unchanged.