fix(ui): render VAG vehicle brand configuration - #1510
Merged
Merged
Conversation
Contributor
Author
|
Hardware validation completed successfully on a real ARM64 FTW installation. Validated build:
PR #1510 is hardware-validated and ready to merge. |
Contributor
Author
|
@frahlg Could you please review/merge this when you have a chance? All checks are green, there are no base-branch conflicts, and the PR has now been hardware-validated on a real ARM64 FTW installation (see validation above). |
Core now merges DRIVER.http_hosts into the allowlist, so the settings page no longer replaces capabilities.http.allowed_hosts on render. That replacement dropped any host the operator had added. Also drop the hint about pasting a cookie, since the cookie field is hidden, and gofmt the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thanks @segran2, and thanks for the hardware validation. I pushed one small commit (d126277) before merging:
I also merged master into the branch. It merges once CI is green. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DRIVER.http_hostsdeclaration, so older saved configs and connection probes can use automatic VAG sign-in without operator-supplied cloud hostsRoot cause
VAG v0.2.0 declares its fixed cloud boundary in
DRIVER.http_hosts, but Core previously builtHostEnv.HTTPAllowedHostsonly from saved YAML/config. Existing VAG configs therefore reachedhost.http_requestwith an empty allowlist and automatic sign-in failed with:http_request: requires a non-empty allowed_hostsThe Settings UI also identified VAG by a filename-only check. A managed/repository driver path could therefore be misclassified as a TeslaBLEProxy-style vehicle and render Proxy IP instead of the VAG credentials.
Verification
Previously validated on the branch:
npm test: 684 tests / 94 suites passed./scripts/ci-local.sh: passed before the latest focused fixesvcs.modified=falsego test ./internal/drivers/...passed on the Core allowlist fixLatest IRL ARM64 validation used clean build
6de237e8b49e827b3b42d93e2546a0d59a019205(vcs.modified=false).Hardware / IRL validation
Validated against a real Audi through the VW Group EU Data Act portal.
Before the Core fix, both ordinary VAG startup and Test connection selected
sign-in=emailbut failed with the empty-allowlist error above.After the Core fix:
sign-in=emailThe returned vehicle dataset was about 15.5 hours old during validation. That telemetry freshness is separate from authentication and this PR does not claim to fix it.
Safety / compatibility
The allowlist is hydrated only from driver-authored
DRIVER.http_hosts; arbitrary operator input is not used to grant VAG cloud hosts. Explicit configured HTTP hosts are retained and merged for drivers that need them.The legacy VAG Cookie is not deleted or overwritten. It remains available in config for compatibility, but is hidden from the normal VAG setup because v0.2.0+ uses Email + Password for automatic re-login.
A separate hardware-CI FTW process was left untouched during IRL testing.