Repository navigation
fix(api): test connections with current OAuth credentials - #1507
Conversation
Share persisted OAuth state with Test connection only when the probe matches the saved driver name and Lua file. An explicit new token is not overwritten or written back onto the live driver. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
|
Hardware validation / follow-up from a real FTW site (v0.139.2-beta.6 candidate): The shared-refresh-token race described in this PR was reproduced on beta.5: after a successful MyUplink Test connection, the probe rotated/persisted the shared refresh token while the live A follow-up fix was tested that restarts the live driver after a probe successfully changes a shared persisted secret (probe removal first, then
The candidate change was also covered by targeted tests for restart-on-rotation and no-restart-when-unchanged, This provides physical-hardware confirmation that restarting the live driver after probe rotation resolves the stale in-memory refresh-token failure mode. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…able-oauth-probe-signed-20261006 Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
a7c27b3 to
54b3bc7
Compare
6f762ef to
95ede97
Compare
…able-oauth-probe-signed-20261006 Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Refs #1502. Depends on #1508. Includes the commits from #1517.
Test connection now uses the configured driver's current OAuth token instead of the original YAML token. It shares secrets only for the same saved name and Lua file. An explicit replacement token stays separate from the working account.
The probe uses the credential owner from #1508 for reads and durable writes. After a changed shared token has been saved and the probe removed, it restarts the configured live driver so that driver loads the new token. An unchanged token does not restart the driver. The restart target comes from the matched live driver, addressing the review on #1517.
Regression tests use a credential owner that differs from the display name and check the token actually read by the restarted Lua driver. Both changed-token and unchanged-token tests failed before the owner integration and now pass.
Validation: targeted API tests,
make verify, and race-detector tests for config, state and driver probes pass on the combined branch. The earlier rotation/restart fix also has the hardware evidence recorded in #1517; the combined owner integration has not yet run on that customer's box.