fix(pixii): report measured power in the right direction - #1504
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Hardware validation completed successfully on a real Pixii Home system using FTW test build Test: driver-scoped battery manual hold, 500 W discharge for 30 s. Observed control chain:
Relevant driver log: This verifies the full sign path on physical hardware: FTW discharge uses negative site power, converts to positive Pixii-native power for the command, and measured/readback power is converted back to the FTW site-sign convention correctly. The manual hold was cleared after the test. The test build was stopped and the system was returned to the official |
Pixii 2.1.7 reversed measured AC power when checking whether the battery followed a command. A real discharge of -1231 W therefore read as +1231 W and raised power_wrong_direction while the flow view showed discharge. This pin brings Pixii 2.1.8 into Core and preserves the measured sign. Command and setpoint conversion stay the same.
Paired with srcfl/device-drivers#155; fixes srcfl/device-drivers#154. The contributor reported charging and discharging checks on a real Pixii Home in that PR. Firmware was not recorded, so that evidence does not cover every Pixii model or firmware.
Validation:
PR #1449 also touches the bundle pin and adds vehicle drivers. Its source pin predates current master. This fix keeps the current bundle list; #1449 should retain this newer source pin when rebased.