Conversation
Signed-off-by: Göran Andersson <goran@andersson-stehag.se>
Contributor
Author
|
Closed without commit, Var det något problem med denna? Med vänlig hälsning,GöranSkickat från min iPad3 okt. 2026 kl. 07:42 skrev Fredrik Ahlgren ***@***.***>:
Closed #1501.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
When the car's cloud reading was stale, the charging planner could use the assumed 20% plug-in level even though the car was at 86%. On an 86.5 kWh Audi with a 90% goal, this produced a roughly 60 kWh plan instead of about 3.9 kWh including charging losses.
Scheduled charging now waits for a valid car anchor or a user-confirmed starting level. The user can correct the slider or confirm that the older reported percentage matches the car now. Older telemetry keeps its age; confirming the starting level does not make the cloud reading fresh.
The Car charging card always shows its goal, including when no charging is needed:
Car SoC target 80% < actual SoC 86% (Confirmed by user).It uses ≥ when the target is at least the displayed actual level. Source labels distinguishFrom Car · Current,Confirmed by user, an older car reading with age, andFTW estimate.The household battery forecast is labelled
Home battery, so it cannot be confused with the car's level.Scope and safety
vehicle-soc-max-age-20m, commitf585074c35f7606317159331521e5a2be48a66b7. Only this PR's 19 files and 289 added / 11 removed lines belong to the change. Retarget and rebase onto master after that dependency lands.Verification
Re-run after applying the test4 changes on the #1500 head:
npm test: 690 passing tests, 94 suites.go test ./internal/loadpoint ./internal/mpc ./cmd/ftw: pass.go test ./internal/api -skip TestHandleSysInfoSmoke: pass.go vet ./...: pass.git diff --check: pass.make verify: not green in this environment. Tests fail when they need network-interface/netlink access or changing file ownership: sysinfo, gatewayidentity, mdnsresolve, nova and scanner. Those environment limitations were also observed on the unmodified v0.139.0-beta.1 baseline. The Make target stops at tests, so its later build checks are not claimed as passed.New regression tests cover waiting for confirmed SoC, blocking cached automatic dispatch, session provenance and restore, target display without charging windows, both comparison directions, source labels, and the stale-reading confirmation UI.
Human/site evidence: the tester reviewed the rendered preview and installed test4 (
v0.139.0-beta.9004) on one FTW site with Audi e-tron / Easee. Confirming 86% with a 90% target reduced the plan to about 3.9 kWh. The tester confirmed the updated UI after restarting the FTW app. The deployed test4 build was based on v0.139.0-beta.1, not the combined #1500 branch; the stacked branch has automated verification only. Multi-site and full physical-dispatch validation remain outstanding.Checklist