Repository navigation
fix: simplify electricity connection setup - #1478
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Setup asked users for an ambiguous voltage value, making it easy to enter the 400 V between phases where FTW expects 230 V from phase to neutral. It also silently used 16 A when the main fuse field was empty.
The wizard now asks for country, three-phase or single-phase connection, and the confirmed main fuse rating. Voltage stays under Advanced. An unknown connection or missing fuse blocks saving with guidance. Settings shows saved custom connections and preserves their values until the user changes them. Fresh installs can load the full country and price-zone list from Core.
Scope and safety
No power calculations, config schema or saved values change. Standard choices explicitly set 230 V; country changes never alter electrical values. Custom phase counts, voltages and safety margins survive an unchanged Settings save. The wizard still replaces config when rerun; this does not make it an additive editor.
PR #1051 also touches setup.html/setup.js for static prices. Its reviews and diff were read. The owner reviewed this result and requested a separate merge; this PR leaves that price work out. The webapp has no electrical setup editor, so this change belongs in Core.
Verification
npm test: 642 passed, zero failures.make verify: all checks passed, including tests, vet and build.Checklist