Repository navigation
fix: make install paths explicit and stop failed setup commands - #1476
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00b60fa1de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sudo docker compose version | ||
| sudo docker buildx version | ||
| sudo docker info >/dev/null | ||
| mkdir "$HOME/ftw-local" |
There was a problem hiding this comment.
When either curl fails—for example because a syntactically valid tag is unpublished or the network drops—set -e exits after creating ~/ftw-local. Every corrected retry then fails at mkdir, while the new error guidance tells the user not to delete that directory, leaving the documented installation path without a recovery step. Download into a temporary directory first, or trap cleanup only for the directory created by this invocation so pre-existing projects remain protected.
AGENTS.md reference: AGENTS.md:L24-L25
Useful? React with 👍 / 👎.
1 participant
A user followed the update guide on the old Pi card, then tried Docker after the native installer refused it. Failed downloads did not stop the command block, and a rebuild tried to read private
data/applink.jsonfiles. This change makes the card swap explicit before installation and fixes the commands that allowed that sequence..dockerignoreto exclude private data and.env. Write it locally in the guide so the fix also works with releases that predate the new file. Check Compose and Buildx before creating the project.Validation: reproduced
checking context: no permission to read .../data/applink.jsonwith an unreadable dummy file and the legacy builder. The fixed context passes both a legacy-builder and a BuildKit build and excludes dummy data,.envand an old installer. Eight tests execute the guide's command blocks with stubbed downloads and Docker: bad tags, 404 on either Docker file followed by a successful retry, stale installer, missing Buildx, existing directory and success.make verifypasses, including the new tests and context build. Confirmed that the current published tag has both Docker files. Inspected both guides rendered on GitHub and checked their internal links.No customer host was changed and no beta was published. The context test uses a scratch image and dummy files; it does not start FTW. The documentation can be used with existing releases immediately.
Paired website change: srcfl/ftw-web#15. Open website PRs #7, #8 and #9 change other sections; this change leaves them intact. Core #1051 has a separate README price section; this change only edits installation copy.