fix(plan): match Core household planning styles - #76
Merged
Merged
Conversation
The Plan screen uses the forecast slider and battery-export choice already on the box. Passive and Active are no longer buttons. Use the plan asks for the mode the box maps from those prefs. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ftw-webapp | b335369 | Commit Preview URL Branch Preview URL |
Oct 04 2026, 03:49 PM |
The simulator catalogue still called idle "Idle". The box renamed the label and tooltip; the key is still idle. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
frahlg
changed the title
frahlg
marked this pull request as ready for review
October 4, 2026 16:08
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract-pair: srcfl/ftw@cursor/plan-household-prefs-1a28
The Plan screen still offered Passive arbitrage and Active arbitrage after Core moved to household planning preferences. It now shows Core's five planning styles: Very careful, Careful, Balanced, Bold and Very bold. Their stored values and help match Core, including the Balanced default of 0.3. Fine-tuning stays available behind a disclosure.
Battery export has its own permission. Each command sends only the preference the user changed, so choosing a style cannot overwrite an export choice made by another client. A delayed preference read cannot replace a newer choice. Manual modes stay behind Manual; Use the plan reads Core's mapped_mode and falls back to the mode that blocks battery sales when that read fails.
Paired with srcfl/ftw#1479 for the session command. Native app PR srcfl/ftw-app#7 keeps its registry snapshot in step. No hardware or production deployment has been tested here.
Validation:
npm run verify: 1,058 tests passed, one skipped; type check and production build passed.The existing PRs keep their scope; no new planner modes or safety rules are added.