Repository navigation
Conversation
srcful-data-models#10 merged v3.0.0 on main, so the host.emit migration note no longer describes it as open or says main is v2.0.0. NovaCore's change (srcful-novacore#174) is still open, and host emit keys stay separate from the wire model as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: David Mozart <dmozartandraws@gmail.com>
The data model is published as v2 (package 2.0.0) on main, not v3. Update the migration note: json.v2 subjects next to the legacy json.v1 with no translation between them, the DER type as the default topic segment (solar, was pv) with NovaCore's temporary pv fallback, the inverter DER as the AC output stage only, an _ac/_dc postfix on every W/V/A/VA/Wh field with only Hz bare, and null for unread values. The split between host emit keys and the wire model is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: David Mozart <dmozartandraws@gmail.com>
davmoz
force-pushed
the
docs/data-models-v3-merged
branch
from
October 6, 2026 12:42
f5e2a7a to
37584a4
Compare
davmoz
changed the title
set_make takes the brand, which v2 hosts write lowercase with `_`; the SoC window rule; NovaCore's v2 path (#174) is merged and on devnet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: David Mozart <dmozartandraws@gmail.com>
davmoz
force-pushed
the
docs/data-models-v3-merged
branch
from
October 7, 2026 05:52
d083ed6 to
8bb28a5
Compare
miravoss26
reviewed
Oct 7, 2026
miravoss26
left a comment
miravoss26
left a comment
There was a problem hiding this comment.
Docs-only spec update: finalizes the data-models v2 migration note (host.set_make brand-casing rule, der_name defaults, v2 payload topic, inverter DER type as AC-only). Replaces the "proposed v3.0.0" language with "v2 (2.3.0) is on main" now that srcful-novacore#174 merged.
- Content checks out against what I can see elsewhere today (srcful-data-models 2.3.0, the matching doc-pointer PRs in srcful-documentation/srcful-ems-x/srcful-device-support).
- No code changed, no host.emit behavior changed — correctly flagged as still pending.
Safe to merge from my read.
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #153. srcful-data-models is published as v2 (package 2.3.0) on
main(8432bf0), not as v3. NovaCore's v2 path (srcfl/srcful-novacore#174) is merged and runs on devnet.What
spec/host-api.md:host.set_make: pass the brand, not the model ("Eastron", not"SDM630"); v2 hosts write it lowercase with words joined by_.docs/REFERENCE.md, and summarises v2 (versionedjson.v2subjects, default DER segment and NovaCore's temporarypvfallback, theinverterDER type,_ac/_dcpostfixes,nullfor unread values, the battery SoC window).inverterrow of theder_typetable: added in data-models v2.host.emitkeys. Hosts must accept or map the v2 wire names before a driver uses them.🤖 Generated with Claude Code