Conversation
Signed-off-by: Segran <goran@andersson-stehag.se>
miravoss26
reviewed
Oct 5, 2026
miravoss26
left a comment
There was a problem hiding this comment.
Mira's read (pr-steward sweep). 2-line summary: MyUplink F750 telemetry. BT7 relabel, degree-minutes as a canonical metric, the -32768 sentinel is ignored, and soft hyphens are stripped from metric names. The driver stays read-only (control: false unchanged).
Checks: the size (18431) and sha256 pinned in index.yaml and manifests/myuplink.yaml match the driver file at this head. The new harness test covers the F750 payload, including the sentinel and soft-hyphen cases.
Findings:
- [low]
decode_tempused to emit0for a missing value and now emits nothing. That's the intent, but it changes what dashboards see for an absent point. Worth one changelog line.
Security screen: no secrets, no new hosts or endpoints.
Safe to merge from my read. Not auto-merge eligible (repo not on the POLICY allowlist), so a human merges.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve NIBE F750 telemetry using parameter data observed on real F750 hardware through MyUplink Cloud API v2.
The change:
hp_degree_minutes-32768unavailable-value sentinel instead of emitting bogus telemetryNo F750 electrical compressor-power mapping is added. Parameter 10012 was not present in the hardware capture, so the driver does not infer electrical power from unrelated parameters.
Driver evidence
myuplink/v2/devices/{deviceId}/pointshp_power_wmapping is claimed for F750Observed parameters include:
40004— BT1 outdoor temperature40013— BT7 hot-water top temperature40033— BT50 room temperature40940— current degree-minute value (DM)41778— current compressor frequency43084— internal additional-heat power-32768— unavailable-value sentinel observed on multiple pointsSafety
The driver remains read-only. This PR adds no control/write path.
Control evidence
Not applicable — read-only telemetry change.
required: not applicableChecks
Signed-off-by.make test-driver ID=myuplinkmake checkFull
make check: 4810 passed, 923 skipped.All 91 drivers passed the sandbox safety check. Manifest, index, devices and support-status generation are clean. FTW baseline and host API checks also passed.