Repository navigation
feat: a favicon, the s of the wordmark over one of its bundles on a tile, with a bitmap for a home screen - #32
Merged
Merged
Conversation
…ile, with a bitmap for a home screen Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The page had no icon. This one is drawn from the wordmark of #30: the
sof the name, large, over the left of its two bundles, on a rounded tile. The tile isgray 12and the lines and the lettergray 1, the page's foreground and background, and they swap underprefers-color-scheme: darkas the page does, so the tab's icon follows the scheme in Chrome and Firefox.The file.
public/icon.svg, 4 kB, copied to the root of the build as it is, linked fromindex.htmlasimage/svg+xml. The lines are the mark's own path data, the bundle's five lines at a heavier stroke, cropped to the tile. Thesis Geist Bold, a step heavier than the mark's SemiBold so it holds at 16 px, outlined withopentype.jsfrom the package's TTF and centred on its ink, since an icon cannot reach the page's fonts, with a knockout around it in the tile's colour as the mark has around the name. The colours are literal hex, the gray tokens' values, because an icon cannot read the page's custom properties either.The bitmap.
public/apple-touch-icon.png, 180 by 180, the light scheme rendered from the SVG, for Safari, iOS and a home screen, which take no SVG.img-src 'self'in the policy covers both.CLAUDE.mdgains thepublic/line in the layout.The tests
pnpm test:e2e # 21 testspage.spec.ts: the icon is linked, served asimage/svg+xml, carries the dark scheme, and the touch icon is served asimage/png. The suite's check for asecuritypolicyviolationcovers the fetch.🤖 Generated with Claude Code