Repository navigation
chore(deps-dev): bump the tooling group with 9 updates, with two tests mended for the Firefox of Playwright 1.64 - #31
Merged
Merged
Conversation
…ates Bumps the tooling group with 9 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@playwright/test](https://github.com/microsoft/playwright) | `1.63.0` | `1.64.0` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `26.6.4` | `26.6.5` | | [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react) | `6.1.1` | `6.1.2` | | [oxc-transform-react](https://github.com/oxc-project/oxc/tree/HEAD/napi/transform-react) | `0.152.0` | `0.153.0` | | [oxfmt](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxfmt) | `0.71.0` | `0.72.0` | | [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint) | `1.86.0` | `1.87.0` | | [playwright](https://github.com/microsoft/playwright) | `1.63.0` | `1.64.0` | | [shadcn](https://github.com/shadcn-ui/ui/tree/HEAD/packages/shadcn) | `4.21.1` | `4.21.4` | | [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `8.3.2` | `8.3.4` | Updates `@playwright/test` from 1.63.0 to 1.64.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.63.0...v1.64.0) Updates `@types/node` from 26.6.4 to 26.6.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `@vitejs/plugin-react` from 6.1.1 to 6.1.2 - [Release notes](https://github.com/vitejs/vite-plugin-react/releases) - [Changelog](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite-plugin-react/commits/plugin-react@6.1.2/packages/plugin-react) Updates `oxc-transform-react` from 0.152.0 to 0.153.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/napi/transform-react/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/crates_v0.153.0/napi/transform-react) Updates `oxfmt` from 0.71.0 to 0.72.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxfmt/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxfmt_v0.72.0/npm/oxfmt) Updates `oxlint` from 1.86.0 to 1.87.0 - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.87.0/npm/oxlint) Updates `playwright` from 1.63.0 to 1.64.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.63.0...v1.64.0) Updates `shadcn` from 4.21.1 to 4.21.4 - [Release notes](https://github.com/shadcn-ui/ui/releases) - [Changelog](https://github.com/shadcn-ui/ui/blob/main/packages/shadcn/CHANGELOG.md) - [Commits](https://github.com/shadcn-ui/ui/commits/shadcn@4.21.4/packages/shadcn) Updates `vite` from 8.3.2 to 8.3.4 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.4/packages/vite) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.64.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: tooling - dependency-name: "@types/node" dependency-version: 26.6.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: tooling - dependency-name: "@vitejs/plugin-react" dependency-version: 6.1.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: tooling - dependency-name: oxc-transform-react dependency-version: 0.153.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: tooling - dependency-name: oxfmt dependency-version: 0.72.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: tooling - dependency-name: oxlint dependency-version: 1.87.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: tooling - dependency-name: playwright dependency-version: 1.64.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: tooling - dependency-name: shadcn dependency-version: 4.21.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: tooling - dependency-name: vite dependency-version: 8.3.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: tooling ... Signed-off-by: dependabot[bot] <support@github.com>
…lit handle's waits for its focus From the last focusable element on the page a tab leaves the document, and the Firefox build of Playwright 1.64 then keeps the field the active element, as it does when the window goes, so the field stayed open and the test timed out looking for the button. The split handle's test typed before Firefox had given the handle the focus. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Dependabot's #29, rebased on
main, with one commit on top. The bump is unchanged:@playwright/testandplaywright1.63.0 to 1.64.0,@types/node26.6.4 to 26.6.5,@vitejs/plugin-react6.1.1 to 6.1.2,oxc-transform-react0.152.0 to 0.153.0,oxfmt0.71.0 to 0.72.0,oxlint1.86.0 to 1.87.0,shadcn4.21.1 to 4.21.4,vite8.3.2 to 8.3.4.What failed. Three Firefox tests, all in the test setup and none in the page. Playwright 1.64 ships a new Firefox build, and in it a tab from the last focusable element on the page leaves the document and keeps the field the active element, which is exactly what the zoom field treats as the window going (it leaves the field open for when the window comes back). The zoom field's tests tabbed out of the only focusable element, so the field never closed and the next click timed out looking for the button. The split handle's test gave the handle the focus from script and typed in the same tick, which the new Firefox sometimes misses. The lucide bump, still on Playwright 1.63, hit the zoom field one once too, so part of it was there before.
The fix. The zoom field's tests render a button after the field, as the third one already did, so a tab stays in the document. The split handle's test waits for the handle to have the focus before it types.
The tests
Closes #29.
🤖 Generated with Claude Code