Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42f3f3ee6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlpage.regex_matchMatches a text value against a regular expression and returns the capture groups as a JSON object.
If the text matches the pattern, the result contains one entry for each capture group that matched:
0contains the full match(?<name>...)use their name as the JSON key( ... )use their numeric index as a stringIf the text does not match, this function returns
NULL.Example: custom routing from
404.sqlThis function is especially useful in a custom
404.sqlpage,where you want to turn a dynamic URL into variables your SQL can use.
For example, suppose you want
/categories/{category}/post/{id}URLs such as/categories/sql/post/42,but there is no physical
categories/sql/post/42.sqlfile on disk.You can put a
categories/404.sqlfile in your project and extract the dynamic parts from the URL:categories/404.sqlIf the current path is
/categories/sql/post/42,sqlpage.regex_match()returns:{"0":"/categories/sql/post/42","category":"sql","id":"42"}You can then use those extracted values to query your database:
Details
\w+matches one or more "word" characters\d+matches one or more digits(?<name>...)creates a named capture group->and->>json_extract($route, ''$.category'')regexcrate documentation:regex syntax reference
NULL, the function returnsNULLThe returned JSON can then be processed with your database''s JSON functions.