"\" at end of comment lines

[gobater]

Mako 1.1.0 is wrongly interpreting backslash ("\") as a newline filter in comments ("##").

Expected behavior: "\" is ignored in comments
Observed behavior: following line is treated as comment

[zzzeek]

unfortunately we have no development resources in Mako to fix issues like these right now.

additionally this would be difficult to change without breaking the backwards compatibility of some template that is relying upon this behavior so im not sure this should be fixed, it might be better just to document it.

[rahulatrkm]

I have a fix ready that separates ## comment matching from % control-line matching. This makes comments end at the physical newline while preserving backslash continuation for control statements. The branch includes LF/CRLF regression coverage, documentation, and passes the full test suite (574 tests).

Would a maintainer be willing to add the open for pull requests label so I can submit it? Branch: https://github.com/rahulatrkm/mako/tree/fix-issue-307-comment-backslash

[zzzeek]

sure, let's do it