make `JdbcEventPublicationAutoConfiguration` class public

[mjd507]

I was writing a slice integration test that need the EventPublicationRepository bean to verify the incomplete and completed event publications.

I see the JdbcEventPublicationAutoConfiguration will config the EventPublicationRepository.

however, I can not use @ImportAutoConfiguration(classes = {JdbcEventPublicationAutoConfiguration.class}) because it not public.

I think at least for slice test, it is useful to make it public, or how we can elegantly achieve this?

[dlwhdgus0810]

Ran into the same limitation writing a @JdbcTest slice for event publications. Opened #1863 which makes the class public and adds a slice test outside the package.

[odrotbohm]

I think we should rather make sure that the JDBC-specific auto configuration is included when using the corresponding slice test annotations out of the box. There's precedent for that kind of integration in our Flyway support.

[dlwhdgus0810]

Thanks, that makes sense. I reworked #1863 accordingly: the JDBC event publication auto-configuration is now registered for @JdbcTest (and thus @DataJdbcTest) via an AutoConfigureJdbc.imports file, together with the Jackson serializer configurations as optional entries, since the repository needs a serializer.

[odrotbohm]

Appreciated, thanks for that. I'll use the chance to implement this for all data stores that we support right away, though.

[odrotbohm]

Re-evaluating the consequences of the anticipated changes, could you both please elaborate on why you'd need to include the Event Publication Repository autoconfiguration explicitly in the first place? There are aspects that make me unsure whether we should proceed with any of what we've planned in the first place.

• @JdbcTest and @DataJdbcTest are intended to only test the application data access layer in the first place. Why would that interact with the Event Publication Repositories then? The latter should only be needed if an EventPublicationRegistry instance is active in the ApplicationContext, which I don't really see a place for in a test focused on testing application repositories.
• As you mentioned, including Event Publication Repositories in an execution implies the presence of an EventPublicationSerializer. If the former automatically triggers the autoconfiguration for the Jackson implementation of that, we severely start to undermine the purpose of the horizontal slice tests in the first place. Most, if not all, folks expect the @…JdbcTest annotations to not bootstrap any application components not related to database infrastructure, such as JSON serialization, etc.

So I would like to take a step back and better understand what you're trying to achieve here.

I was writing a slice integration test that need the EventPublicationRepository bean to verify the incomplete and completed event publications.

This sounds as if you're trying to test what the integration tests in Modulith already test anyway, doesn't it?

[mjd507]

This sounds as if you're trying to test what the integration tests in Modulith already test anyway, doesn't it?

Seems so.
As a user, when choosing Modulith for the outbox pattern, I just want to ensure the records actually exist in the outbox table.
Shouldn't I?