Repository navigation
Conversation
Prior to this commit, CompositeMatcher.match indexed the buffer byte by byte through DataBuffer.getByte. Some DataBuffer implementations record an access for each call (for example, Netty's leak-aware buffers capture a stack trace when paranoid leak detection is enabled), so matching a multipart body made parsing orders of magnitude slower and multipart requests timed out. This commit uses DataBuffer.forEachByte instead, which delegates to the underlying implementation's bulk path, as the previous NestedMatcher implementation did. Signed-off-by: Hyunsik Kang <cj848@hanmail.net>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
DataBuffers.CompositeMatcher.matchindexed the buffer byte by bytethrough
DataBuffer.getByte. SomeDataBufferimplementations record an access for everycall: Netty's leak-aware buffers capture a stack trace per access when paranoid leak
detection is enabled, so matching a multipart body became orders of magnitude slower.
With Spring Framework 7.1.0, a WebFlux application using
PartEventHttpMessageReaderonNetty with
-Dio.netty.leakDetection.level=paranoidsees multipart uploads time out(408 responses, multi-second and multi-minute hangs) while the event loop spends its time
in
AdvancedLeakAwareByteBuf.getByte.This commit uses
DataBuffer.forEachByteinstead, which delegates to the underlyingimplementation's bulk path, as the previous
NestedMatcherimplementation did. The newtest verifies that the matcher does not call
DataBuffer.getByte.