Repository navigation
Sort declared methods for deterministic CGLIB classes - #37730
Open
algomaster99 wants to merge 2 commits into
Open
algomaster99 wants to merge 2 commits into
algomaster99 wants to merge 2 commits into
Conversation
Signed-off-by: Aman Sharma <mannu.poski10@gmail.com>
Signed-off-by: Aman Sharma <mannu.poski10@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java 25 documentation of
Class.getDeclaredMethods()says this about the order.In practice, the order changes between JVM runs. CGLIB numbers the methods in this order, so the same proxy class gets different bytecode in different runs. This PR sorts the declared methods in
ReflectUtils.addAllMethods()by name and descriptor.I use SBOM.exe, which checks the classes an application loads against an allowlist of their bytecode. In Spring PetClinic,
WebConfiguration$$SpringCGLIB$$0differed between runs. This change helps create a consistent allowlist for Spring-based applications like PetClinic.🤖 Generated with Claude Code