Repository navigation
Conversation
Register the default YAML mapping when a configured message converter supports application/yaml, not application/atom+xml. Add regression tests for YAML-only and Atom-only converter configurations. Signed-off-by: 海子 Yang <i.take.today@gmail.com>
TAKETODAY
force-pushed
the
fix/default-yaml-media-type-mapping
branch
from
November 19, 2026 09:08
351051b to
9b25d3c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebMvcConfigurationSupport#getDefaultMediaTypes()checks forapplication/atom+xmlbefore registering the defaultyamlmapping. As a result, a YAML-only converter configuration misses the mapping, while an Atom-only configuration incorrectly registers it.Evidence
Added two regression tests in
WebMvcConfigurationSupportTests:yamlmappingyamlasapplication/yamlatomandyamlatomBoth tests failed before the fix. After the fix,
./gradlew :spring-webmvc:checkpassed.Merge Danger
Door: Two-way. The change is easy to revert.
Blast Radius: Spring MVC's default
yamlmedia type mapping. Theatommapping and message converter configuration are unchanged.